Skip to content

Conversation

@scunningham
Copy link
Contributor

…d of a frame.

@scunningham scunningham requested review from aleksmaus and Copilot July 29, 2025 18:19
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug where the LZ4 reader could return a zero byte count with a nil error when reading at the end of a frame, which violates the io.Reader interface contract that requires returning io.EOF when no more data is available.

  • Added logic to avoid returning (0, nil) at end of frame by looping back to read more data
  • Added comprehensive test case to verify the fix works correctly

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
internal/pkg/rdr/rdr.go Implements the fix by adding a loop check to avoid (0, nil) returns at end of frame
internal/test/rd_test.go Adds test case TestReadEmptyEnd to verify the reader properly returns EOF instead of (0, nil)
Comments suppressed due to low confidence (1)

internal/test/rd_test.go:328

  • There's a grammatical error in the comment. 'would could a' should be 'would return a' or 'could return a'.
}

@scunningham scunningham merged commit 92f8fad into prequel-dev:main Jul 29, 2025
3 checks passed
@scunningham scunningham deleted the nilread branch July 29, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants