Use TargetFrameworks tag if multiple frameworks are provided by dotnetframework#2727
Use TargetFrameworks tag if multiple frameworks are provided by dotnetframework#2727CapeGuyBen wants to merge 1 commit into
Conversation
| ]] | ||
| end | ||
|
|
||
| function suite.multiple_target_dotnet_frameworks() |
There was a problem hiding this comment.
This has mixed spaces and tabs, should be normalized to tabs.
There was a problem hiding this comment.
test_netcore.lua is now normalised to tabs
| ### Parameters ### | ||
|
|
||
| `version` is one of: | ||
| `versions` is a semicolon separated list of version numbers where each element is one of: |
There was a problem hiding this comment.
Shouldn't we use table for list?
There was a problem hiding this comment.
I would agree. A table would be better.
To follow up, a table input should allow for single inputs as well.
There was a problem hiding this comment.
It could use a list:string? I think that would require a separate dotnetframeworks (plural version) property to avoid breaking backwards compatibility with existing uses of dotnetframework. This would mirror the TargetFramework and TargetFrameworks solution properties.
There was a problem hiding this comment.
I don't believe so. I would need to verify, but it should just let you "append" to a list/table if you have only a single input specified, rather than a table.
There was a problem hiding this comment.
CapeGuyBen
force-pushed
the
feature/targetframeworks
branch
from
89f9cc0 to
2de7d8a
Compare
| ### Parameters ### | ||
|
|
||
| `version` is one of: | ||
| `versions` is a semicolon separated list of version numbers where each element is one of: |
There was a problem hiding this comment.
I would agree. A table would be better.
To follow up, a table input should allow for single inputs as well.
4 participants
What does this PR do?
Allows multiple target .NET frameworks to be supported by a single dotnet project
How does this PR change Premake's behavior?
Extends the
dotnetframeworkproperty to switch from usingTargetFrameworktoTargetFrameworkswhen multiple (semicolon-separated) target names are providedDid you check all the boxes?
closes #XXXXin comment to auto-close issue when PR is merged)