-
Notifications
You must be signed in to change notification settings - Fork 0
docs(azure-vmss): update docs and added examples #890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
011f7b4
docs(azure-vmss): update docs and added examples
pablosanchezpaz c3fe181
docs(azuread-group): update Readme
pablosanchezpaz 1940444
docs(azuread-group): update Readme
pablosanchezpaz 38b1d54
docs(azuread-group): update Readme
pablosanchezpaz 1cc2167
docs(azure-vmss-docss): update Readme
pablosanchezpaz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| formatter: "markdown" | ||
|
|
||
| version: "" | ||
|
|
||
| header-from: docs/header.md | ||
| footer-from: docs/footer.md | ||
|
|
||
| recursive: | ||
| enabled: false | ||
| path: modules | ||
| include-main: true | ||
|
|
||
| sections: | ||
| hide: [] | ||
| show: [] | ||
|
|
||
| content: "" | ||
|
|
||
| output: | ||
| file: "README.md" | ||
| mode: inject | ||
| template: |- | ||
| <!-- BEGIN_TF_DOCS --> | ||
| {{ .Content }} | ||
| <!-- END_TF_DOCS --> | ||
|
|
||
| output-values: | ||
| enabled: false | ||
| from: "" | ||
|
|
||
| sort: | ||
| enabled: true | ||
| by: name | ||
|
|
||
| settings: | ||
| anchor: true | ||
| color: true | ||
| default: true | ||
| description: false | ||
| escape: true | ||
| hide-empty: false | ||
| html: true | ||
| indent: 2 | ||
| lockfile: true | ||
| read-comments: true | ||
| required: true | ||
| sensitive: true | ||
| type: true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| // Basic example: Azure Virtual Machine Scale Set (VMSS) | ||
|
|
||
| module "azure_vmss" { | ||
| source = "../../" | ||
|
|
||
| common = { | ||
| resource_group_name = "example-rg" | ||
| location = "westeurope" | ||
| } | ||
|
|
||
| vmss = { | ||
| name = "example-vmss" | ||
| sku = "Standard_DS2_v2" | ||
| instances = 2 | ||
| admin_username = "azureuser" | ||
| admin_ssh_key_username = "azureuser" | ||
| first_public_key = "<your-ssh-public-key>" | ||
|
|
||
| disk_storage_account_type = "Standard_LRS" | ||
| disk_caching = "ReadWrite" | ||
|
|
||
| upgrade_mode = "Rolling" | ||
| rolling_upgrade_policy_max_batch_instance_percent = 20 | ||
| rolling_upgrade_policy_max_unhealthy_instance_percent = 20 | ||
| rolling_upgrade_policy_max_unhealthy_upgraded_instance_percent = 20 | ||
| rolling_upgrade_policy_pause_time_between_batches = "PT0S" | ||
| rolling_upgrade_policy_cross_zone_upgrades_enabled = true | ||
| rolling_upgrade_policy_maximum_surge_instances_enabled = true | ||
| rolling_upgrade_policy_prioritize_unhealthy_instances_enabled = true | ||
|
|
||
| image_publisher = "Canonical" | ||
| image_offer = "0001-com-ubuntu-server-jammy" | ||
| image_sku = "server" | ||
| image_version = "latest" | ||
|
|
||
| subnet_name = "vmss-subnet" | ||
| virtual_network_name = "example-vnet" | ||
| virtual_network_resource_group_name = "example-rg" | ||
|
|
||
| network_interface_public_ip_adress_public_ip_prefix_id = "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/example-rg/providers/Microsoft.Network/publicIPPrefixes/example-prefix" | ||
|
|
||
| identity_type = "SystemAssigned" | ||
|
|
||
| cloud_init = "#cloud-config" | ||
| run_script = null | ||
| } | ||
|
|
||
| tags = { | ||
| environment = "dev" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| # Basic example values for azure-vmss module | ||
|
|
||
| common: | ||
| resource_group_name: example-rg | ||
| location: westeurope | ||
|
|
||
| vmss: | ||
| name: example-vmss | ||
| sku: Standard_DS2_v2 | ||
| instances: 2 | ||
| admin_username: azureuser | ||
| admin_ssh_key_username: azureuser | ||
| first_public_key: "<your-ssh-public-key>" | ||
|
|
||
| disk_storage_account_type: Standard_LRS | ||
| disk_caching: ReadWrite | ||
|
|
||
| upgrade_mode: Rolling | ||
| rolling_upgrade_policy_max_batch_instance_percent: 20 | ||
| rolling_upgrade_policy_max_unhealthy_instance_percent: 20 | ||
| rolling_upgrade_policy_max_unhealthy_upgraded_instance_percent: 20 | ||
| rolling_upgrade_policy_pause_time_between_batches: PT0S | ||
| rolling_upgrade_policy_cross_zone_upgrades_enabled: true | ||
| rolling_upgrade_policy_maximum_surge_instances_enabled: true | ||
| rolling_upgrade_policy_prioritize_unhealthy_instances_enabled: true | ||
|
|
||
| image_publisher: Canonical | ||
| image_offer: 0001-com-ubuntu-server-jammy | ||
| image_sku: server | ||
| image_version: latest | ||
|
|
||
| subnet_name: vmss-subnet | ||
| virtual_network_name: example-vnet | ||
| virtual_network_resource_group_name: example-rg | ||
|
|
||
| network_interface_public_ip_adress_public_ip_prefix_id: /subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/example-rg/providers/Microsoft.Network/publicIPPrefixes/example-prefix | ||
|
|
||
| identity_type: SystemAssigned | ||
| cloud_init: "#cloud-config" | ||
| run_script: null | ||
|
|
||
| tags: | ||
| environment: dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| ## Examples | ||
|
|
||
| For detailed examples, refer to the [module examples](https://github.com/prefapp/tfm/tree/main/modules/azure-vmss/_examples): | ||
|
|
||
| - [basic](https://github.com/prefapp/tfm/tree/main/modules/azure-vmss/_examples/basic) - Basic Linux VM Scale Set with rolling upgrade and custom image configuration. | ||
|
|
||
| ## Resources and support | ||
|
|
||
| - [Official Azure Virtual Machine Scale Set documentation](https://learn.microsoft.com/en-us/azure/virtual-machine-scale-sets/) | ||
| - [Terraform reference for azurerm_linux_virtual_machine_scale_set](https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/linux_virtual_machine_scale_set) | ||
| - [Terraform reference for azurerm_virtual_machine_scale_set_extension](https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/virtual_machine_scale_set_extension) | ||
|
|
||
| ## Support | ||
|
|
||
| For issues, questions, or contributions related to this module, please visit the [repository's issue tracker](https://github.com/prefapp/tfm/issues). |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
README.mdnow contains a large block of content before<!-- BEGIN_TF_DOCS -->. In other modules in this repo, the README is fully managed inside the terraform-docs inject markers (the file starts withBEGIN_TF_DOCS), otherwise the documentation is duplicated andterraform-docswon't manage the preamble. Consider removing the pre-marker content (or switching terraform-docs output mode) so the README is fully generated consistently.