Skip to content

Remove newlines#137

Open
frmadem wants to merge 2 commits intomasterfrom
feature/remove-unnecessary-newlines
Open

Remove newlines#137
frmadem wants to merge 2 commits intomasterfrom
feature/remove-unnecessary-newlines

Conversation

@frmadem
Copy link
Contributor

@frmadem frmadem commented Sep 21, 2021

Related to #136

@frmadem
Copy link
Contributor Author

frmadem commented Sep 21, 2021

@AlbertoFemeniasI'm trying to remove as many newlines as I can. The problem is that it has to be done carefully in order to avoid trim to many newlines!! cfr.

Could you test it in our charts? You just need to substitute the base's Chart.yaml reference to prefapp-helm to a file:/// reference (pointing to the path you have download this repo).

@frmadem
Copy link
Contributor Author

frmadem commented Sep 21, 2021

This doc seems interesting also!

@AlbertoFemenias
Copy link
Contributor

Seems to be working, but still a lot of new lines:

  spec: 
      
      
      containers: 
        
        
          - name: app
            image: "prefappacr.azurecr.io/apps/backend/hellok8s:1a5332f"
            imagePullPolicy: IfNotPresent
            
            command: 
              - "npm"
              - "run"
              - "start"
            
            
            env: 
            
            - name: KUBERNETES_IMAGE
              value: "prefappacr.azurecr.io/apps/backend/hellok8s:1a5332f"
            - name: PORT
              value: "8080"
            
            
            - name: KUBERNETES_HOST_IP
              valueFrom:
                fieldRef:
                  fieldPath: status.hostIP
            - name: KUBERNETES_NAMESPACE
              valueFrom:
                fieldRef:
                  fieldPath: metadata.namespace
            - name: KUBERNETES_NODE_NAME
              valueFrom:
                fieldRef:
                  fieldPath: spec.nodeName
            - name: KUBERNETES_POD_IP
              valueFrom:
                fieldRef:
                  fieldPath: status.podIP
            - name: KUBERNETES_POD_NAME
              valueFrom:
                fieldRef:
                  fieldPath: metadata.name
            
            envFrom: 
            
            - configMapRef:
                name: RELEASE-NAME-frontend
            ports: 
            - containerPort: 8080
              protocol: TCP
          
            volumeMounts: 
              
            resources: 
              requests: 
                  {}
              limits: 
                  {} 
            
            
      
      
      
      
      
      
      
      
      imagePullSecrets: 
        
      
      volumes:

@AlbertoFemenias
Copy link
Contributor

@frmadem Could you check my changes do not break anything?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants