Add solids4foam to the system tests#838
Draft
MakisH wants to merge 17 commits into
Draft
Conversation
This reverts commit 4767bb5.
MakisH
commented
Jul 10, 2026
Member
Author
There was a problem hiding this comment.
Cherry-picked #872 for testing. Revert / update.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a solids4foam component and adds the solids4foam tutorial case to the system tests.
To avoid building it from scratch every time that a previous build stage is updated, I am defining an independent build stage based on the official solids4foam image (FYI @philipcardiff: this image is useful! 🙏).
Since the image is based on Ubuntu 22.04, and since anyway we test the adapter and the respective tutorial with various preCICE versions, I am using a fixed version of preCICE from scratch. I thought of moving that to a different Dockerfile, but a bug in the system tests currently prevents that: #873
Keeping the two components (
openfoam-adapterandsolids4foam) independent also allows them to use different OpenFOAM versions.To be able to test a complete simulation (test run), I cherry-picked the current state of #872. I will clean this up before merging.