Updating the site to begin the Appnexus adpater#6627
Conversation
decpreatction and to rename elements to Microsoft.
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hi @jsnellbaker and adrianmason@microsoft.com, please review. |
| **Notes on s2sConfig properties** | ||
|
|
||
| - Currently supported vendors are: appnexus, openx, and rubicon | ||
| - Currently supported vendors are: msft, openx, and rubicon |
There was a problem hiding this comment.
[important] This supported-vendors note is part of the stale defaultVendor documentation. Since current Prebid.js no longer uses defaultVendor to supply endpoint defaults, this line should be removed rather than renamed to a different vendor.
— Copilot
|
|
||
| - Currently supported vendors are: appnexus, openx, and rubicon | ||
| - Currently supported vendors are: msft, openx, and rubicon | ||
| - When using `defaultVendor` option, `accountId` still needs to be defined. |
There was a problem hiding this comment.
[important] This defaultVendor note should be removed or marked legacy-only. Current s2sConfig examples should require explicit endpoint / syncEndpoint values instead of suggesting vendor defaults still apply.
— Copilot
| accountId: '1', | ||
| bidders: ['tripleliftVideo'], | ||
| defaultVendor: 'appnexus', | ||
| defaultVendor: 'appnexuspsp', |
There was a problem hiding this comment.
[important] This server-side alias example still uses defaultVendor. Please update it so the example is vendor-agnostic and includes explicit placeholder endpoint / syncEndpoint values, or mark the defaultVendor form as legacy-only.
— Copilot
| | --- | --- | --- | --- | --- | --- | | ||
| | prebidServerAccountId | either | string | init | Your Prebid Server team will tell you whether this is required or not and if so, the value. | "abc123" | | ||
| | prebidServerHost | optional | enum | init | Starting from PrebidMobile `3.0.0` the property is removed<wbr>This can take the values "Appnexus", "Rubicon", or "Custom". If "Custom", you need to use the setCustomPrebidServerUrl() method to set a URL. This is where the Prebid SDK will send the auction information. Your Prebid Server team will tell you which value to use. The default is "Custom". | "Custom" | | ||
| | prebidServerHost | optional | enum | init | Starting from PrebidMobile `3.0.0` the property is removed<wbr>This can take the values "Microsoft", "Rubicon", or "Custom". If "Custom", you need to use the setCustomPrebidServerUrl() method to set a URL. This is where the Prebid SDK will send the auction information. Your Prebid Server team will tell you which value to use. The default is "Custom". | "Custom" | |
There was a problem hiding this comment.
[important] This row documents the removed pre-3.0 iOS API, so the enum values should stay literal to the old SDK API. I checked prebid/prebid-mobile-ios tag 2.5.2: PrebidHost has cases Appnexus, Rubicon, and Custom; there is no Microsoft case.
Recommended final state: either keep the historical enum list as "Appnexus", "Rubicon", or "Custom", or remove the old enum-value list entirely and point readers to the current custom host URL API. Please don’t change this removed API’s literal enum value to "Microsoft" unless the SDK actually exposed that value.
— Copilot
There was a problem hiding this comment.
[important] GitHub would not allow inline comments on every unchanged line in this file, so collecting the remaining defaultVendor cleanup items here. These instances should still be removed or marked legacy-only:
line 84: defaultvendor-row
line 148: defaultvendor-approach-text
line 262: video-defaultvendor
Final state: this doc should use vendor-agnostic s2sConfig examples with explicit placeholder �ndpoint / syncEndpoint values. It should not teach current users that defaultVendor supplies endpoint defaults.
— Copilot
3 participants
Pages updated to reflect the move to the MSFT adapter.
🏷 Type of documentation