Skip to content

Conversation

@CTMBNara
Copy link
Collaborator

🔧 Type of changes

  • new bid adapter
  • bid adapter update
  • new feature
  • new analytics adapter
  • new module
  • module update
  • bugfix
  • documentation
  • configuration
  • dependency update
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

What's the context for the changes?

🧠 Rationale behind the change

Why did you choose to make these changes? Were there any trade-offs you had to consider?

🔎 New Bid Adapter Checklist

  • verify email contact works
  • NO fully dynamic hostnames
  • geographic host parameters are NOT required
  • direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
  • if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
  • cover an adapter configuration with an integration test

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

@CTMBNara CTMBNara requested a review from And1sS November 24, 2025 16:55
@CTMBNara CTMBNara marked this pull request as ready for review December 3, 2025 01:41
@github-actions
Copy link

github-actions bot commented Dec 3, 2025

TestsPassed ✅Skipped ⚠️Failed
JUnit Test Report9158 ran9156 passed2 skipped0 failed

@And1sS And1sS added the do not merge Not the time for merging yet label Dec 3, 2025
@osulzhenko osulzhenko added the work in progress Signals not finished work label Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not merge Not the time for merging yet work in progress Signals not finished work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants