Skip to content

Conversation

@marki1an
Copy link
Collaborator

@marki1an marki1an commented Nov 21, 2025

🔧 Type of changes

  • new bid adapter
  • bid adapter update
  • new feature
  • new analytics adapter
  • new module
  • module update
  • bugfix
  • dependency update
  • documentation
  • configuration
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

Added a few options for mvn -verify

  1. -Drun-functional-tests=(true/false) (running core functional tests without module tests)
  2. -Drun-module-functional-tests=(true/false) (running module functional tests without a core)

Added a profile for running functional tests locally without modifying a pom file.

🧠 Rationale behind the change

Why did you choose to make these changes? Were there any trade-offs you had to consider?

🔎 New Bid Adapter Checklist

  • verify email contact works
  • NO fully dynamic hostnames
  • geographic host parameters are NOT required
  • direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
  • if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
  • cover an adapter configuration with an integration test

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

@marki1an marki1an self-assigned this Nov 21, 2025
@marki1an marki1an added the tests Functional or other tests label Nov 21, 2025
@osulzhenko osulzhenko added the work in progress Signals not finished work label Nov 21, 2025
@marki1an marki1an removed the work in progress Signals not finished work label Nov 24, 2025
@osulzhenko osulzhenko self-requested a review December 10, 2025 13:18
@marki1an marki1an requested review from osulzhenko and removed request for osulzhenko December 22, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not port PBS 4.0 tests Functional or other tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants