Tests: Support GET interface profiles #4239

osulzhenko · 2025-10-14T18:28:36Z

🔧 Type of changes

✨ What's the context?

What's the context for the changes?

🧠 Rationale behind the change

Why did you choose to make these changes? Were there any trade-offs you had to consider?

🔎 New Bid Adapter Checklist

verify email contact works
NO fully dynamic hostnames
geographic host parameters are NOT required
direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
cover an adapter configuration with an integration test

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

Are your changes following our code style guidelines?
Are there any breaking changes in your code?
Does your test coverage exceed 90%?
Are there any erroneous console logs, debuggers or leftover code in your changes?

marki1an

Please add validation for get parameters

marki1an · 2025-11-03T11:10:00Z

src/test/groovy/org/prebid/server/functional/model/request/get/GeneralGetRequest.groovy

+    @JsonProperty("sarid")
+    String storedAuctionResponseId
+
+    @JsonProperty("mimes")


No, really needed here JsonProperty

marki1an · 2025-11-03T11:12:05Z

src/test/groovy/org/prebid/server/functional/model/request/get/GeneralGetRequest.groovy

+    @JsonProperty("oh")
+    Integer originalHeight
+
+    @JsonProperty("sizes")


marki1an · 2025-11-03T11:12:11Z

src/test/groovy/org/prebid/server/functional/model/request/get/GeneralGetRequest.groovy

+    @JsonProperty("ms")
+    Object sizesLegacy
+
+    @JsonProperty("slot")


Check for similar occurrences

marki1an · 2025-11-03T11:17:57Z

src/test/groovy/org/prebid/server/functional/model/request/get/GeneralGetRequest.groovy

+    List<Integer> api
+
+    @JsonProperty("battr")
+    List<Integer> battr


Better naming for it blockAttributes

marki1an · 2025-11-03T11:26:37Z

src/test/groovy/org/prebid/server/functional/model/request/get/GeneralGetRequest.groovy

+    Integer podSequence
+
+    @JsonProperty("proto")
+    List<Integer> proto


Please rename to protocols

marki1an · 2025-11-04T10:05:01Z

src/test/groovy/org/prebid/server/functional/tests/GeneralGetInterfaceImpSpec.groovy

+        and: "Bidder request should contain mimes from param"
+        def bidderRequest = bidder.getBidderRequest(request.id)
+        assert bidderRequest.imp.size() == 1
+        assert bidderRequest.imp.first.getProperty(impMediaType.value).mimes == [mimes]


I'd like to propose creating a utility method to get this field, since we will often use it, and it will be faster than using getProperty.

Add in where block null value when mimes not defined.

Comment applicable to all tests

marki1an · 2025-11-04T10:21:46Z

src/test/groovy/org/prebid/server/functional/tests/GeneralGetInterfaceImpSpec.groovy

+        impMediaType << [
+                MediaType.BANNER,
+                MediaType.VIDEO,
+                MediaType.AUDIO
+        ]


In one line, please

marki1an · 2025-11-04T11:15:14Z

src/test/groovy/org/prebid/server/functional/tests/GeneralGetInterfaceImpSpec.groovy

+            it.mimes = [mimes]
+        }
+
+        "Default stored request"


Mino: missing and:

marki1an · 2025-11-04T11:23:46Z

src/test/groovy/org/prebid/server/functional/tests/GeneralGetInterfaceImpSpec.groovy

+        }
+    }
+
+    def "PBS should apply ow and oh for banner imp from general get request when it's specified"() {


You can merge with PBS should apply width and height for banner imp from general get request when it's specified

marki1an · 2025-11-04T12:03:46Z

src/test/groovy/org/prebid/server/functional/tests/GeneralGetInterfaceImpSpec.groovy

+        and: "Default bid response"
+        def bidResponse = BidResponse.getDefaultBidResponse(request)
+        bidder.setResponse(request.id, bidResponse)


You can remove bid response since it's present in BaseSpec

Please take a look at this comment

marki1an · 2025-11-14T08:03:28Z

src/test/groovy/org/prebid/server/functional/tests/GeneralGetInterfaceImpSpec.groovy

+        and: "Default bid response"
+        def bidResponse = BidResponse.getDefaultBidResponse(request)
+        bidder.setResponse(request.id, bidResponse)


Please take a look at this comment

marki1an · 2025-11-14T08:04:34Z

src/test/groovy/org/prebid/server/functional/tests/GeneralGetInterfaceImpSpec.groovy

+        given: "Default General get request"
+        def validMemis = PBSUtils.randomString
+        def generalGetRequest = GeneralGetRequest.default.tap {
+            it.mimes = (invalidMimes + validMemis)


What about "$invalid $valid"?

marki1an · 2025-11-14T08:16:39Z

src/test/groovy/org/prebid/server/functional/tests/GeneralGetInterfaceImpSpec.groovy

+
+    def "PBS should apply width and height for banner imp from general get request when banner width and height are square dimensions"() {
+        given: "Default General get request"
+        def side = PBSUtils.getRandomNumber(0, 10)


marki1an · 2025-11-14T08:19:43Z

src/test/groovy/org/prebid/server/functional/tests/GeneralGetInterfaceImpSpec.groovy

+
+    def "PBS should apply sizes banner imp from general get request when banner width and height are square dimensions"() {
+        given: "Default General get request"
+        def side = PBSUtils.getRandomNumber(0, 10)


Same here: Why side

marki1an · 2025-11-14T08:59:35Z

src/test/groovy/org/prebid/server/functional/tests/GeneralGetInterfaceImpSpec.groovy

+        impMediaType << [
+                MediaType.VIDEO,
+                MediaType.AUDIO
+        ]


Suggested change

impMediaType << [

MediaType.VIDEO,

MediaType.AUDIO

]

impMediaType << [MediaType.VIDEO, MediaType.AUDIO]

marki1an · 2025-11-14T09:01:02Z

src/test/groovy/org/prebid/server/functional/tests/GeneralGetInterfaceImpSpec.groovy

+        ]
+    }
+
+    def "PBS should apply api from general get request when it's specified"() {


What if not specified?

It would be nice to see all tests with a negative scenario when not specified

marki1an · 2025-11-14T09:01:36Z

src/test/groovy/org/prebid/server/functional/tests/GeneralGetInterfaceImpSpec.groovy

+        and: "Default bid response"
+        def bidResponse = BidResponse.getDefaultBidResponse(request)
+        bidder.setResponse(request.id, bidResponse)


Please remove it

Same for others

marki1an · 2025-11-14T09:06:40Z

src/test/groovy/org/prebid/server/functional/tests/GeneralGetInterfaceImpSpec.groovy

+        assert bidderRequest.imp.first.video.linearity == linearityParam
+    }
+
+    def "PBS should apply minbr from general get request when it's specified"() {


PBS should apply minbr and maxbr from general get request when it's specified

marki1an · 2025-11-14T09:27:18Z

src/test/groovy/org/prebid/server/functional/tests/GeneralGetInterfaceImpSpec.groovy

+        assert !response.ext?.errors
+        assert !response.ext?.warnings
+
+        and: "Bidder request should contain boxingallowed from param"


typo: "playbackmethod"

marki1an · 2025-11-14T09:27:27Z

src/test/groovy/org/prebid/server/functional/tests/GeneralGetInterfaceImpSpec.groovy

+        assert !response.ext?.errors
+        assert !response.ext?.warnings
+
+        and: "Bidder request should contain boxingallowed from param"


…terface

…-get-interface

marki1an · 2025-11-14T17:29:13Z

src/test/groovy/org/prebid/server/functional/tests/ProfileSpec.groovy

+        storedRequestDao.save(storedRequest)
+
+        when: "PBS processes general get request"
+        def response = pbsWithStoredProfiles.(getRequest)


.sendGeneralGetRequest

marki1an · 2025-12-01T18:06:48Z

src/test/groovy/org/prebid/server/functional/tests/GeneralGetInterfaceImpSpec.groovy

+        when: "PBS processes amp request"
+        defaultPbsService.sendGeneralGetRequest(generalGetRequest)
+
+        then: "Amp response should contain value from targeting in imp.ext.data"


It's not amp response.

marki1an · 2025-12-01T18:08:27Z

src/test/groovy/org/prebid/server/functional/tests/ProfileSpec.groovy

    }

-    def "PBS should throw exception when profiles are not configured for filesystem and request contain profileId"() {
+    def "PBS should process request when profiles are not configured for filesystem and request contain profileId"() {


process request with a warning

marki1an · 2025-12-02T11:07:55Z

.../groovy/org/prebid/server/functional/model/request/auction/ConsentedProvidersSettings.groovy

+import groovy.transform.EqualsAndHashCode
 import groovy.transform.ToString

+@EqualsAndHashCode


I hope you don't need it

Also, check other cases, please remove when it's not really needed

We need all of them; it's part of the verification process

marki1an · 2025-12-02T11:11:33Z

src/test/groovy/org/prebid/server/functional/model/request/auction/Device.groovy

 import groovy.transform.ToString
 import org.prebid.server.functional.util.PBSUtils

+@EqualsAndHashCode


Same don't need, since you comparing by fields

marki1an · 2025-12-02T13:06:35Z

...test/groovy/org/prebid/server/functional/tests/privacy/GeneralGetInterfacePrivacySpec.groovy

+        assert !response.ext?.errors
+        assert !response.ext?.warnings
+
+        and: "Bidder request should contain addtlConsent from param"


"Bidder request should contain regs.gpp from param"

marki1an · 2025-12-02T13:07:08Z

...test/groovy/org/prebid/server/functional/tests/privacy/GeneralGetInterfacePrivacySpec.groovy

+            it.ext == new RegsExt()
+        }
+
+        and: "PBS should cansel request"


marki1an · 2025-12-02T13:11:19Z

src/test/groovy/org/prebid/server/functional/tests/GeneralGetInterfaceRequestSpec.groovy

+        assert !response.ext?.errors
+        assert !response.ext?.warnings
+
+        and: "Bidder request should be valid"


"PBs should preform bidder request"

marki1an · 2025-12-02T13:12:34Z

src/test/groovy/org/prebid/server/functional/tests/GeneralGetInterfaceRequestSpec.groovy

+        assert !response.ext?.errors
+        assert !response.ext?.warnings
+
+        and: "Bidder request should contain outputformat from param"


"Bidder request should contain outputModule from param"

marki1an · 2025-12-02T13:13:14Z

src/test/groovy/org/prebid/server/functional/tests/GeneralGetInterfaceRequestSpec.groovy

+        assert !response.ext?.errors
+        assert !response.ext?.warnings
+
+        and: "Bidder request should contain gpc from param"


"Bidder request should contain dnt from param"

Check others for typos

Tests: Support GET interface profiles

5a880fb

osulzhenko self-assigned this Oct 14, 2025

osulzhenko added the work in progress Signals not finished work label Oct 14, 2025

osulzhenko marked this pull request as draft October 14, 2025 18:28

osulzhenko requested a review from marki1an October 23, 2025 15:51

Add functional tests for /get endpoint parameters

1dd7157

osulzhenko removed the work in progress Signals not finished work label Oct 29, 2025

osulzhenko marked this pull request as ready for review October 29, 2025 12:03

marki1an added the tests Functional or other tests label Nov 3, 2025

marki1an requested changes Nov 4, 2025

View reviewed changes

update after review

f6543e2

marki1an requested changes Nov 14, 2025

View reviewed changes

osulzhenko added 3 commits November 17, 2025 14:14

Merge branch 'refs/heads/master' into functional-tests/general-get-in…

10060d3

…terface

update get interface tests

5126e00

Merge branch 'refs/heads/get-interface' into functional-tests/general…

c981e37

…-get-interface

osulzhenko changed the base branch from master to get-interface November 20, 2025 08:30

osulzhenko added 7 commits November 21, 2025 15:18

Merge branch 'refs/heads/get-interface' into functional-tests/general…

a1a49d3

…-get-interface

Merge branch 'refs/heads/get-interface' into functional-tests/general…

934ea4a

…-get-interface

update tests

bb42e74

Merge branch 'refs/heads/get-interface' into functional-tests/general…

3b5c276

…-get-interface

update tests

25e4ff6

update privacy tests

c88a5a2

Increase test coverage

6ba1166

osulzhenko requested a review from marki1an November 26, 2025 10:04

marki1an requested changes Dec 2, 2025

View reviewed changes

osulzhenko requested a review from marki1an December 4, 2025 18:09

update after review

5056fdd

osulzhenko force-pushed the functional-tests/general-get-interface branch from 934cb46 to 5056fdd Compare December 5, 2025 09:40

marki1an requested review from marki1an and removed request for marki1an December 22, 2025 10:22

Tests: Support GET interface profiles #4239

Are you sure you want to change the base?

Tests: Support GET interface profiles #4239

Uh oh!

Conversation

osulzhenko commented Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔧 Type of changes

✨ What's the context?

🧠 Rationale behind the change

🔎 New Bid Adapter Checklist

🧪 Test plan

🏎 Quality check

Uh oh!

marki1an left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

osulzhenko commented Oct 14, 2025 •

edited

Loading