LunamediaHB Bid Adapter: transfer maintenance to Ferio#15099
Conversation
|
Tread carefully! This PR adds 119 linter errors (possibly disabled through directives):
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ae7525ac39
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| ...createFerioBidderSpec({ | ||
| code: BIDDER_CODE, | ||
| endpoint: LUNAMEDIAHB_ENDPOINT, | ||
| requiredParams: ["tenantId"], | ||
| }), |
There was a problem hiding this comment.
When COPPA is enabled (config.setConfig({ coppa: true })), this replacement moves Lunamedia from teqblazeUtils.getUserSyncs, which appended coppa=1, to Ferio's getUserSyncs, which only adds GDPR/USP/GPP query params. That means Lunamedia user-sync pixels/iframes are still registered but no longer carry the child-privacy flag, so COPPA-enabled pages can sync without the signal the previous adapter always sent.
Useful? React with 👍 / 👎.
Barecheck - Code coverage reportTotal: 96.5%Your code coverage diff: 0.00% ▴ ✅ All code changes are covered |
| | ------------- | -------- | ------ | ---------------------------------------- | | ||
| | `publisherId` | required | String | Publisher ID on the Lunamedia platform. | | ||
| | `adUnitId` | required | String | Ad unit ID on the Lunamedia platform. | | ||
| | `tenantId` | required | String | Tenant ID on the Lunamedia platform. | |
There was a problem hiding this comment.
You can't require new params in a minor version
There was a problem hiding this comment.
Got it. Can we remove the lunamediahb adapter and incorporate it as a ferio adapter alias within minor version?
2 participants
Type of change
Summary
Maintainer verification
Ferio is taking over maintenance of the LunamediaHB adapter. Can be verified with Luna Media at
prebid@lunamedia.io.Docs
Docs PR prepared in
prebid.github.io: prebid/prebid.github.io#6568