iPROM Bid Adapter: support ortb/endpoint params and relax dimension requirement#14573
iPROM Bid Adapter: support ortb/endpoint params and relax dimension requirement#14573iprom-adserver wants to merge 14 commits intoprebid:masterfrom
Conversation
… request grouping Move endpoint and ortb config from bidder-level config to per-ad-unit params. buildRequests now groups bids by (endpoint, ortb) and returns an array of requests, allowing different ad units to target different endpoints with different payload formats independently. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add reachedTop, numIframes, and stack from refererInfo to site.ext in the ORTB payload via a custom request processor on ortbConverter. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 94508d4908
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| const groups = {}; | ||
|
|
||
| for (const bid of validBidRequests) { | ||
| const endpoint = resolveEndpoint(bid.params.endpoint); |
There was a problem hiding this comment.
The new endpoint routing only looks at bid.params.endpoint, so pages that set the endpoint through pbjs.setBidderConfig still fall back to the default URL. In Prebid, bidder-level overrides are exposed through bidder config (not automatically copied into every bid params object), so this implementation misses the advertised per-page override path and will silently send traffic to the wrong endpoint in that setup.
Useful? React with 👍 / 👎.
| logError(`${bidder}: Parameter 'id' needs to be a string`); | ||
| } | ||
|
|
||
| if (params.dimension && typeof params.dimension !== 'string') { |
There was a problem hiding this comment.
The dimension type check is gated by truthiness, so falsy non-string values like 0 or false pass validation even though they are invalid dimensions. Those values are then propagated into the outbound payload (imp.ext.bidder.dimension in ORTB mode), which can break downstream parsing and is hard for publishers to diagnose because the adapter reports the request as valid.
Useful? React with 👍 / 👎.
|
Tread carefully! This PR adds 2 linter errors (possibly disabled through directives):
|
Pull Request Test Coverage Report for Build 23298333448Details
💛 - Coveralls |
3 participants
Type of change
Updated bidder adapter
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Description of change
Updates to iPROM bid adapter:
ad unit configurations
ortbparameter to control the shape of the bid request payloadendpointparameter for per-page endpoint configurationvia setBidderConfig
Other information