Skip to content

New adapter adsmovil#14551

Merged
jsnellbaker merged 7 commits intoprebid:masterfrom
Adsmovil-sas:master
Apr 10, 2026
Merged

New adapter adsmovil#14551
jsnellbaker merged 7 commits intoprebid:masterfrom
Adsmovil-sas:master

Conversation

@teqblaze
Copy link
Copy Markdown
Contributor

@teqblaze teqblaze commented Mar 5, 2026

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Updated bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

Other information

doc MR: prebid/prebid.github.io#6461

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 42b645ce4f

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread modules/adsmovilBidAdapter.js Outdated
@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Mar 6, 2026

Coverage Report for CI Build 24187944110

Coverage increased (+0.001%) to 96.343%

Details

  • Coverage increased (+0.001%) from the base build.
  • Patch coverage: 6 uncovered changes across 1 file (211 of 217 lines covered, 97.24%).
  • 3 coverage regressions across 2 files.

Uncovered Changes

File Changed Covered %
test/spec/modules/adsmovilBidAdapter_spec.js 211 205 97.16%

Coverage Regressions

3 previously-covered lines in 2 files lost coverage.

File Lines Losing Coverage Coverage
modules/widespaceBidAdapter.js 2 83.67%
modules/browsiAnalyticsAdapter.js 1 92.31%

Coverage Stats

Coverage Status
Relevant Lines: 225163
Covered Lines: 216928
Line Coverage: 96.34%
Relevant Branches: 52489
Covered Branches: 42624
Branch Coverage: 81.21%
Branches in Coverage %: No
Coverage Strength: 72.92 hits per line

💛 - Coveralls

@jsnellbaker
Copy link
Copy Markdown
Collaborator

Hello @teqblaze

I was attempting to use this adapter with the hello_world page in the project to test the e2e ad delivery. However I'm seeing the following error from the ad server endpoint, can you please take a look?

Access to fetch at 'https://tag-ssp.adsmovil.com/pbjs' from origin 'http://test.localhost:9999' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource.

@teqblaze
Copy link
Copy Markdown
Contributor Author

Hi, @jsnellbaker. Sorry for this. It is in process. I will notify you when we'll fix it

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 8, 2026

Whoa there partner! This project is migrating to typescript. Consider changing the new JS files to TS, with well-defined types for what interacts with the prebid public API (for example: bid params and configuration). Thanks!

  • modules/adsmovilBidAdapter.js

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2026

Whoa there partner! This project is migrating to typescript. Consider changing the new JS files to TS, with well-defined types for what interacts with the prebid public API (for example: bid params and configuration). Thanks!

  • modules/adsmovilBidAdapter.js

@teqblaze
Copy link
Copy Markdown
Contributor Author

teqblaze commented Apr 9, 2026

Hi, @jsnellbaker! Please, check new changes

Comment thread modules/adsmovilBidAdapter.ts
@jsnellbaker jsnellbaker merged commit 8737cf0 into prebid:master Apr 10, 2026
102 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants