fix(types): ensure forwardRef overrides the default ref type#4787
Open
aleclarson wants to merge 1 commit intopreactjs:mainfrom
Open
fix(types): ensure forwardRef overrides the default ref type#4787aleclarson wants to merge 1 commit intopreactjs:mainfrom
forwardRef overrides the default ref type#4787aleclarson wants to merge 1 commit intopreactjs:mainfrom
Conversation
📊 Tachometer Benchmark ResultsSummaryA summary of the benchmark results will show here once they finish. ResultsThe full results of your benchmarks will show here once they finish. |
rschristian
reviewed
Jun 6, 2025
Comment on lines
+89
to
+90
| export interface FunctionComponent<P = {}, RefType = any> { | ||
| (props: RenderableProps<P, RefType>, context?: any): ComponentChildren; |
Member
There was a problem hiding this comment.
I don't think this is the correct solution, React's FunctionComponent type does not take a second generic param so we shouldn't either.
It looks like the return type of forwardRef should be altered instead.
Edit: We do also have TS tests, in both core & compat, adding this case to one or both of those tests would be appreciated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue with
forwardRefthat was leading to a type conflict, which was basically…Try to assign the
refprop of a forwardRef component to a ref callback, its argument's type defaults toanyno matter the component type.Reproduction