Skip to content

Modal test02#7

Open
prayush wants to merge 4 commits intodevelopfrom
modalTest02
Open

Modal test02#7
prayush wants to merge 4 commits intodevelopfrom
modalTest02

Conversation

@prayush
Copy link
Copy Markdown
Owner

@prayush prayush commented Sep 19, 2018

Proposed changes

Types of changes:

  • Bugfix
  • New feature

Component:

  • Code
  • Documentation
  • Build system
  • Continuous integration

Code review checklist

  • The PR passes all checks, including unit tests, clang-tidy and IWYU. For
    instructions on how to perform the CI checks locally refer to the Dev guide
    on the Travis CI
    .
  • The code is documented and the documentation renders correctly. Run make doc
    to generate the documentation locally into BUILD_DIR/docs/html. Then open
    index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.

Further comments

prayush pushed a commit that referenced this pull request Mar 1, 2019
@prayush prayush force-pushed the develop branch 3 times, most recently from 2fbdea5 to 0600ff3 Compare May 15, 2019 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant