Skip to content

Improve sharpness removal: re-enable Sharpness field...#1701

Draft
Koeleskab wants to merge 1 commit into
praydog:masterfrom
Koeleskab:patch-1
Draft

Improve sharpness removal: re-enable Sharpness field...#1701
Koeleskab wants to merge 1 commit into
praydog:masterfrom
Koeleskab:patch-1

Conversation

@Koeleskab
Copy link
Copy Markdown

...override and change default behavior to sharpness off

  • Uncomment and enable Sharpness field to apply sharpness values
  • UI toggle sets sharpness to 1.0 when enabled, 0.0 when disabled. Defaults to disable.
  • Removed broken + redundant slider.
  • Initialize wanted_sharpness to 0.0 to conform with user expected behavior when using sharpness removal
  • Remove debug_disable flag for simpler code

This ensures intuitive default behavior when moved to autorun or manually run and simplifies user-configuration.

…nge default behavior to sharpness off

- Uncomment and enable Sharpness field to apply sharpness values
- Add smart UI toggle that sets sharpness to 1.0 when enabled, 0.0 when disabled. Defaults to disable.
- Removed broken + redundant slider.
- Initialize wanted_sharpness to 0.0 for clean image on boot
- Remove debug_disable flag for simpler code

This ensures intuitive default behavior when moved to autorun and simplifies user-configuration.
@Koeleskab Koeleskab marked this pull request as draft April 9, 2026 10:21
@Koeleskab
Copy link
Copy Markdown
Author

My refactoring of the UI was based on a misconception due to a discrepancy in how RE3 and RE2 handle the sharpness value. I was a bit quick on the trigger. But did some direct object inspection in REFramework yesterday.

The actual problem was that RE2 allows setting sharpness on TaaStrength.disabled while it doesn't on TaaStrength.strong. When sharpness gets set to 1 in Re2 while TaaStrength.disable is also set, the field actually gets set to TaaStrength.Legacy. Re3 ignores the wanted_sharpness value and just enacts sharpness based on TaaStrength enum except when it's set to manual or Legacy explicitly.

so the fix seems to be: wanted_sharpness = 0 when TaaStrength.Disabled. That way both games work. Table for clarity:

Scenario Input: TAA Enum Input: Sharpness RE2 Result RE3 Result
TAA Enabled Strong 0.0 - 1.0 Locked: Enforces 0.5 sharpness; ignores user input. Locked: Enforces 0.5 sharpness; ignores user input.
TAA Disabled Disable 1.0 Conflict: Interprets this as Legacy TAA. Clean: TAA is off; image is sharpened.
Current Fix Disable 0.0 disables TAA without triggering Legacy mode. disables TAA;

My PR might be a tad overkill, but it does set a clear behavior for both games that fit the expectation of the mod, at the loss of already removed slider-control.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant