Revert visibility change on special chat bubbles#58
Open
zbarbuto wants to merge 1 commit intoprahack:masterfrom
Open
Revert visibility change on special chat bubbles#58zbarbuto wants to merge 1 commit intoprahack:masterfrom
zbarbuto wants to merge 1 commit intoprahack:masterfrom
Conversation
Author
|
@prahack Would you mind taking a look at this please? 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In version 1.7.0 (see #56 or, more specifically, a431ae9), SpecialChatBubbles were changed from public to private. However, these components were previously public and are used in downstream applications. Making them private introduced a breaking change, which should have been released as a major version bump (2.0.0) as per Semantic Versioning.
This PR reverts the visibility change, making SpecialChatBubbles public again to restore backward compatibility allowing apps that used these special bubbles to also work with the latest Flutter version.
Alternatively, if the idea is to phase these out, they can be flagged as
@deprecatedinstead.