Skip to content

Finer targets#97

Merged
pragmatrix merged 3 commits intomasterfrom
finer-targets
Feb 3, 2026
Merged

Finer targets#97
pragmatrix merged 3 commits intomasterfrom
finer-targets

Conversation

@pragmatrix
Copy link
Owner

This PR fixes the parent navigation, so that groups are focused first when navigating up.

@pragmatrix pragmatrix requested a review from Copilot February 3, 2026 05:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the focus and navigation system by flattening the target hierarchy. Instead of nested variants like Band(BandTarget) and Project(ProjectTarget), targets are now direct enum variants (Instance, View, ProjectGroup, ProjectLauncher). This simplification makes group-first parent navigation possible and improves the clarity of focus path handling.

Changes:

  • Flattened DesktopTarget enum variants to remove nested types
  • Replaced band_location() with instance_parent() for more precise parent targeting
  • Removed from_instance_and_view() helper in favor of explicit path construction

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
desktop/src/desktop_presenter.rs Flattens DesktopTarget enum, adds conversion traits, updates navigation and camera logic to handle new flat structure
desktop/src/desktop_interaction.rs Removes make_foreground() method and simplifies event processing by using focus() directly
desktop/src/desktop.rs Updates focus path construction to use explicit target vectors instead of helper methods

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@pragmatrix pragmatrix merged commit 7140a2e into master Feb 3, 2026
0 of 4 checks passed
@pragmatrix pragmatrix deleted the finer-targets branch February 3, 2026 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant