Merged
Conversation
…tance and also the focus from what's currently focused
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the focus and navigation system by flattening the target hierarchy. Instead of nested variants like Band(BandTarget) and Project(ProjectTarget), targets are now direct enum variants (Instance, View, ProjectGroup, ProjectLauncher). This simplification makes group-first parent navigation possible and improves the clarity of focus path handling.
Changes:
- Flattened
DesktopTargetenum variants to remove nested types - Replaced
band_location()withinstance_parent()for more precise parent targeting - Removed
from_instance_and_view()helper in favor of explicit path construction
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| desktop/src/desktop_presenter.rs | Flattens DesktopTarget enum, adds conversion traits, updates navigation and camera logic to handle new flat structure |
| desktop/src/desktop_interaction.rs | Removes make_foreground() method and simplifies event processing by using focus() directly |
| desktop/src/desktop.rs | Updates focus path construction to use explicit target vectors instead of helper methods |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the parent navigation, so that groups are focused first when navigating up.