Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces support for passing configuration parameters from launch profiles to instance environments. Parameters are now represented as a Map<String, Value> from serde_json, replacing the custom Parameters and Parameter types. The parameters flow from TOML configuration through launch profiles and user intents to the instance environment where applications can access them.
Changes:
- Replaced custom parameter types with
serde_json::Map<String, Value>for better type flexibility - Modified
CreationMode::Newto carryInstanceParameters - Added
InstanceContext::parameters()method for accessing parameters during instance creation
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| desktop/src/projects/configuration/types.rs | Removed custom Parameters and Parameter types; changed LaunchProfile.params to use Map<String, Value> |
| desktop/src/projects/configuration/toml_reader.rs | Updated TOML parsing to convert values directly to serde_json::Value instead of strings |
| desktop/src/projects/launcher_presenter.rs | Added parameters field to StartInstance user intent |
| desktop/src/desktop_interaction.rs | Updated UserIntent::StartInstance to include InstanceParameters field |
| desktop/src/desktop.rs | Modified instance spawning to pass parameters through CreationMode::New |
| applications/src/instance_environment.rs | Added parameters field and with_parameters builder method |
| applications/src/instance_context.rs | Changed CreationMode::New to carry parameters; added parameters() accessor method |
| desktop/src/instance_manager.rs | Removed unused creation_mode field from RunningInstance |
| desktop/src/projects/mod.rs | Simplified parameter initialization using Default::default() |
| Cargo.toml | Updated serde_json version from 1.0.116 to 1.0.149 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to pass the parameters from the configuration to the instance's environment.