Start Instances from LauncherPresenter#95
Merged
pragmatrix merged 13 commits intomasterfrom Jan 30, 2026
Merged
Conversation
…rtInstance intent, so that launchers can use it too
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables launching application instances from launcher presenters in the project view, extending the band-based instance management system to support multiple locations for presenting instances.
Changes:
- Added
UserIntentreturn values to event processing methods to propagate instance launch requests up the presenter hierarchy - Extended
BandPresenterfunctionality to launcher presenters, allowing each launcher to manage its own band of instances - Introduced
BandLocationenum to distinguish between top-level band and launcher-specific bands - Refactored event routing and focus path handling to support nested band navigation within project launchers
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| shapes/src/shape.rs | Added architectural comment about color field duplication |
| shapes/src/glyph_run.rs | Added builder method for setting text color |
| scene/src/objects.rs | Added Clone derive to Visual with explanatory comment |
| scene/src/handle.rs | Added conditional update method with performance comments |
| layout/src/layouter.rs | Changed callback signature to pass parameters separately |
| geometry/src/lib.rs | Added ToPixels trait for Point conversion |
| desktop/src/projects/project_presenter.rs | Updated to return UserIntent and handle band navigation |
| desktop/src/projects/mod.rs | Added Band variant to ProjectTarget enum |
| desktop/src/projects/launcher_presenter.rs | Extended with band presentation and instance management |
| desktop/src/lib.rs | Added box_to_rect layout helper function |
| desktop/src/focus_target.rs | Suppressed unused warnings |
| desktop/src/focus_path.rs | Moved PartialEq constraint to impl blocks |
| desktop/src/event_router.rs | Updated Default bound with PartialEq |
| desktop/src/desktop_presenter.rs | Refactored to support multiple band locations |
| desktop/src/desktop_interaction.rs | Updated interaction handling for UserIntent propagation |
| desktop/src/desktop.rs | Enhanced instance creation with band location support |
| desktop/src/band_presenter.rs | Made originating_from optional with default panel size |
Comments suppressed due to low confidence (1)
desktop/src/projects/launcher_presenter.rs:1
- Corrected spelling of 'exist' to 'exists'.
use std::time::{Duration, Instant};
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.