This repository was archived by the owner on Jan 12, 2026. It is now read-only.
Bugfix: Multiple command execution on button click#15
Open
onionware-github wants to merge 1 commit intopr8x:masterfrom
Open
Bugfix: Multiple command execution on button click#15onionware-github wants to merge 1 commit intopr8x:masterfrom
onionware-github wants to merge 1 commit intopr8x:masterfrom
Conversation
Contributor
Author
|
Maybe also publish a new Nuget release? |
pr8x
reviewed
Jun 21, 2023
| private void OnNotificationActionInvoked((uint id, string actionKey) @event) | ||
| { | ||
| if (!_activeNotifications.TryGetValue(@event.id, out var notification)) return; | ||
| if (!_activeNotifications.TryGetValue(@event.id, out var notification) || notification is null) return; |
Owner
There was a problem hiding this comment.
When the notification is removed then checking TryGetValue here is enough. It already returns false when the item is not in the dictionary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you click the button in the notification, its possible that the event gets executed multiple times. Now the notification gets removed from the dictionary after the first execution of "OnNotifyActionInvoked" and will be null if the method runs again for the same command.