Enhance/conformu#8
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes several important improvements and corrections to the camera API simulator, focusing on stricter validation, improved error handling, and better adherence to the ASCOM standard for gain/offset and sub-exposure controls. The changes also refactor some behaviors to more accurately simulate real hardware, particularly for subframe validation and pulse guiding.
Key changes include:
Validation and Error Handling Improvements
start_exposure, ensuring that binned subframes are within camera bounds. Setters for these values now only reject obviously invalid input, while full validation is deferred to exposure start. [1] [2] [3] [4] [5]PropertyNotImplementederrors when a feature is not supported (e.g., sub-exposure duration, gain/offset min/max). [1] [2] [3] [4] [5]Gain and Offset List Mode Compliance
PropertyNotImplementedas required by ASCOM. The API models and validation logic have been updated accordingly. [1] [2] [3] [4] [5] [6]Pulse Guiding Simulation
ispulseguidingflag is held true for the requested duration, then cleared, more closely matching real hardware behavior.Miscellaneous Corrections