Enhance/move axis#10
Merged
Merged
Conversation
…z and RA/Dec targets
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request implements significant improvements to the telescope and camera simulation, especially around motion modeling, star trail rendering, and device state management. The main changes include a new unified motion model for the telescope, improved simulation of star trailing in camera exposures, and refactoring of slew and MoveAxis logic for accuracy and maintainability.
Telescope motion and slewing model:
Replaced the previous thread-based async slewing with a background interpolation model. The telescope now smoothly interpolates position toward RA/Dec or Alt/Az targets over time, storing intermediate targets in state (
slew_target_ra,slew_target_dec,slew_target_alt,slew_target_az). This makes slews more realistic and allows for interruption or status queries at any time. [1] [2] [3] [4] [5] [6]Introduced a unified coordinate rate computation (
compute_coordinate_rates) used by both the telescope's internal state updates and the camera's star trail simulation. This ensures that the reported telescope coordinates and the simulated image trailing are always consistent. [1] [2] [3]Camera simulation improvements:
MoveAxis and tracking logic:
Camera gain and configuration:
Detailed list of most important changes:
Telescope motion and slewing model:
compute_coordinate_ratesfunction to unify motion rate calculations for both telescope state updates and camera simulation, ensuring physical consistency. [1] [2] [3]Camera simulation:
MoveAxis and tracking:
Camera gain/configuration: