Open
Conversation
miovd
force-pushed
the
flowtransfer
branch
4 times, most recently
from
27e0d75 to
a7a36c5
Compare
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com> Correct github actions Correct github actions Correct github actions
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
|
Kudos, SonarCloud Quality Gate passed!
|
miovd
approved these changes
Feb 18, 2021
Contributor
miovd
left a comment
miovd
left a comment
There was a problem hiding this comment.
Small comments but the PR is okay to me
Comment on lines
+76
to
+79
| <groupId>com.powsybl</groupId> | ||
| <artifactId>powsybl-iidm-impl</artifactId> | ||
| <version>${powsybl.core.version}</version> | ||
| </dependency> |
Contributor
There was a problem hiding this comment.
this may be only needed in runtime
Comment on lines
+65
to
+67
| <groupId>com.powsybl</groupId> | ||
| <artifactId>powsybl-config-classic</artifactId> | ||
| <version>${powsybl.core.version}</version> |
Contributor
There was a problem hiding this comment.
this may be only needed in runtime
Comment on lines
+60
to
+63
| <groupId>com.rte-france.powsybl</groupId> | ||
| <artifactId>powsybl-hades2-integration</artifactId> | ||
| <version>${powsybl.rte-core.version}</version> | ||
| </dependency> |
Contributor
There was a problem hiding this comment.
this may be only needed in runtime
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the restWhat kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
Other information:
(if any of the questions/checkboxes don't apply, please delete them entirely)