Adjust horizontal centering spacing for rest#542
Adjust horizontal centering spacing for rest#542sbonaime wants to merge 4 commits intopowertab:masterfrom
Conversation
|
Thanks for looking at this! While doing some testing I noticed that the new spacing didn't look as good for some durations like half rests, so perhaps the alignment needs some different settings per type 
|
|
Maybe we should takie into account the width and height of each symbol before placing them. Or maybe at the drawing stage ? Tremolo picking Vibrato Large Vibrato and vibrato |
|
Yeah, there should ideally be some adjustments depending on the symbol I recall it being hard to get accurate information about the width of each symbol from the Qt font info classes, which is why there are a lot of hardcoded scale factors in the layout code. |
There was a problem hiding this comment.
Pull request overview
This PR adjusts the horizontal centering spacing for rest symbols in the music notation renderer to fix issue #540. The change reduces the width allocation for rest centering from 1.25× to 1× the position spacing.
Changes:
- Modified the horizontal centering width calculation for rest symbols to use exactly the position spacing width instead of 1.25× the width
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
I made some changes :
|
|
|
||
| if (symbolGroup.getSymbolType() == SymbolGroup::TremoloPicking) | ||
| { | ||
| renderedSymbol->setY(yPos); |
There was a problem hiding this comment.
I'm not clear how these changes affect the layout
The tremolo picking symbol does this in the case statement above
renderedSymbol->setX(layout.getPositionX(symbolGroup.getLeftPosition()));
which looks equivalent to how the X position is set below in the generic case for other symbols?
2 participants
Description of Change(s)
Adjust horizontal centering spacing for rest
Fixes Issue(s)
Fix #540