-
Notifications
You must be signed in to change notification settings - Fork 73
(feat): Added manageDestinationExternally option to diff trigger creation.
#881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
98c37b1
Added `persistDestination` option to diff trigger creation. Allows th…
Chriztiaan 85869e8
Updating force usage.
Chriztiaan cc187a0
Fixed unit test.
Chriztiaan 8e501da
Switched to `manageDestinationExternally` option instead, escaping al…
Chriztiaan 5477264
Changeset entry.
Chriztiaan 449370f
Merge branch 'main' into feature/persisted-diff-trigger-destination
Chriztiaan d1471dc
Added `createDiffDestinationTable`.
Chriztiaan afa3e60
Comments.
Chriztiaan 3970e50
Externally managed triggers now have a different name pattern, resour…
Chriztiaan c4b6528
Removed tests. Updated comments.
Chriztiaan 2b31a62
Removed logging.
Chriztiaan e3a8fa0
Readded tests.
Chriztiaan 340adf0
Updated default values, no longer obtaining a claim when managing ext…
Chriztiaan 3ccc8e3
Merge branch 'main' into feature/persisted-diff-trigger-destination
Chriztiaan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@powersync/common': minor | ||
| --- | ||
|
|
||
| Added `manageDestinationExternally` option to diff trigger creation, escaping all internal management of the destination table. User is responsible for table creation and cleanup. Added `createDiffDestinationTable` helper method to ease the external creation step. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.