Debian crash fix + Game handle leak fix#10
Conversation
Increments the refcount of the private forward. This prevents a crash on Debian 10 and doesn't seem like well-defined behavior.
|
I also just realised that PR #9 exists, and while I was about to close my PR. As the description of cancel native is as follow : However our event, is fired by nativevotes, it is therefore better to use |
|
I don't think it makes a diff using delete; vs .Cancel? The api specifically mentioned it frees handles lol. And why did you make a PR with other people's changes? Just open an issue Also, I've been maintaining https://github.com/sapphonie/sourcemod-nativevotes-updated as an aggregated "maintained" version of nativevotes, including these changes + updates for 1.10 syntax and other updates for MvM, using the PRs from this repo + people's forks. Just use that |
While it does mention that it frees the event, the api also notes it's for non fired event :
However, if you wish to have your repo as the head, then I've no issue with this and will gladly close this PR! |
Considering those fixes are important, especially the debian crash fix, it'd be great if this PR could be merged. As this repository remains the main source where server operators obtain their copy of nativevotes.