This repository was archived by the owner on Jun 15, 2022. It is now read-only.
Update babel and rename filterFromCollectionByContains to filterFromCollectionByIncludes#22
Open
jcaffey wants to merge 6 commits intopoteto:masterfrom
Open
Update babel and rename filterFromCollectionByContains to filterFromCollectionByIncludes#22jcaffey wants to merge 6 commits intopoteto:masterfrom
jcaffey wants to merge 6 commits intopoteto:masterfrom
Conversation
update babel dep to ^6.14.1
update babel and rename contains => includes
Author
|
@poteto can this be merged and tagged under a new release (obviously not backwards compatible) |
|
Can we please have this merged and published... it's prevent us from upgrading to Ember 3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ember.Array#contains is deprecated and now uses includes to follow along with ESnext. Original ember issue: emberjs/ember.js#13336
This will also keep ember apps from whining about babel 5.x deprecation.