Open
Conversation
pickernickel
force-pushed
the
spigot-1.9
branch
2 times, most recently
from
36c3599 to
801f5b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I updated the methods for piston movement within the creative block logging to make use of the new 1.9 API for retrieving the blocks that will be moved by a piston push. This change fixes the issues with properly logging movements involving slime blocks and a vulnerability with non-solid blocks.
Made the appropriate changes from the comments of Pull Request #1.
Note: Requires plib's Bukkit dependency to be upgraded from 1.9 to 1.9.4-R0.1 as 1.9-SNAPSHOT no longer exists.
Update: The last commit changes the way player inventories are stored to use UUID instead of player name in the file name to avoid possible inventory loss upon name change. Block states for creative logging also now store the UUID instead.