Add Workbench API key and Package Manager token env var support#30
Draft
ian-flores wants to merge 1 commit intomainfrom
Draft
Add Workbench API key and Package Manager token env var support#30ian-flores wants to merge 1 commit intomainfrom
ian-flores wants to merge 1 commit intomainfrom
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #29 — enables VIP to accept pre-generated credentials for all three products via environment variables, supporting the upcoming
ptd verifyK8s Job flow.Changes
WorkbenchConfigwithapi_keyfield reading fromVIP_WORKBENCH_API_KEYPackageManagerConfigwithtokenfield reading fromVIP_PM_TOKENWorkbenchClientandPackageManagerClientto accept and use auth headerstests/conftest.pyfixturesvip.toml.exampleandREADME.mdwith new env varsEnvironment variables
VIP_WORKBENCH_API_KEYVIP_PM_TOKEN