chore: Move tool request hiding logic out of result class#163
Merged
chore: Move tool request hiding logic out of result class#163
Conversation
cpsievert
approved these changes
Dec 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the logic for hiding tool requests to a dedicated event listener, which previously depended on a combination of the request being added to the page and logic in the tool request class. We also add a
.shiny-tool-requestand.shiny-tool-resultclass to the output elements.With this change, custom tool request and result elements don't need to replicate the
shiny-tool-request-hidelogic. To be clear, custom tool request elements aren't currently possible with ellmer (and maybe chatlas?). But custom tool results are possible and without this PR they would need to replicate internal shinychat logic for request hiding to work as expected. The new classes aren't used for styling, but future-proof this code against custom tool request elements (that would use an element other than<shiny-tool-request>).