Add force_node_group_upgrade option for EKS clusters#169
Closed
ian-flores wants to merge 3 commits intomainfrom
Closed
Add force_node_group_upgrade option for EKS clusters#169ian-flores wants to merge 3 commits intomainfrom
ian-flores wants to merge 3 commits intomainfrom
Conversation
Per-cluster opt-in flag (default false) that passes force_update_version to the EKS NodeGroup resource, allowing version updates even when PDBs block pod eviction.
All 15 tests pass, including the 2 new ones. Changes: - Fixed documentation inconsistency: changed example `force_node_group_upgrade` value from `true` to `false` to match `CONFIGURATION.md` and clarify the default behavior - Added tests for `AWSWorkloadClusterConfig.force_node_group_upgrade` field (default value and explicit enable) - Note: the **Medium** finding about the flag only applying to the main node group is not an issue — `_create_node_group` reads the flag from `cluster_cfg` and is called for both the default and additional node groups
Fixes ruff FBT001/FBT002 lint errors.
Contributor
Author
|
Superseded by #168 which covers both AWS and Azure with a unified force_maintenance field. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Per-cluster opt-in flag (
force_node_group_upgrade, defaultfalse) that passesforce_update_versionto the EKSNodeGroupresource, allowing version updates even when Pod Disruption Budgets block pod eviction.This was needed because EKS node group upgrades on ganso01-staging were failing due to Workbench session PDBs with
maxUnavailable: 0.Usage
Category of change
Checklist
ganso01-stagingand confirmed my change works