Revert "Revert "fix: stop overriding team-operator image when not explicitly configured""#166
Open
Revert "Revert "fix: stop overriding team-operator image when not explicitly configured""#166
Conversation
…licitly configured""
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-applies #155: when
team_operator_imageis not set in ptd.yaml, PTD now passes no image override to Helm, allowing the chart to use itsappVersiondefault.Previously, even when
team_operator_chart_versionwas pinned, PTD always overrode the operator image toposit/ptd-team-operator:latest. This meant chart versions controlled Helm values but not the actual operator image running in clusters.Prerequisites (completed):
v1.16.2(https://github.com/rstudio/ptd-config/pull/2808)What changes for existing clusters:
After merging this PR and running ptd ensure, clusters will pull the image version matching their
team_operator_chart_version(via the chart'sappVersion), instead of always pullingposit/ptd-team-operator:latest. Currently all clusters are pinned tov1.16.2(PR linked above).