Conversation
| ) | ||
| switch s.DstTarget.CloudProvider() { | ||
| case types.AWS: | ||
| return s.runAWSInlineGo(ctx, creds, envVars) |
There was a problem hiding this comment.
there's likely a little dry missing here aws vs. azure, but it's probably not so important
|
|
||
| // --- Azure --- | ||
|
|
||
| // azurePostgresParams holds the pre-fetched data needed by the Azure deploy function. |
There was a problem hiding this comment.
unclear on the necessity of this, but it looks like a reasonable choice to me.
| return runPulumi(ctx, stack, s.Options) | ||
| } | ||
|
|
||
| // --- Shared helpers --- |
There was a problem hiding this comment.
this shared helper might belong elsewhere, but it feels pretty unique to this step to me.
| componentType = "ptd:AWSControlRoomPostgresConfig" | ||
| } | ||
|
|
||
| // Helper to create alias pointing to old Python component parent URN. |
There was a problem hiding this comment.
we may want to figure out how to refactor this later to be very generic/work for all steps, since it's the real crux of how to convert these steps between languages without producing diffs/deltas
| ctx.Export("grafana_db_name", grafanaDb.Name) | ||
| ctx.Export("grant_id", grant.ID()) | ||
|
|
||
| // Extra databases (workload only, e.g. soleng for staging workloads) |
There was a problem hiding this comment.
obviously, we shouldn't use this anymore. but i didn't want to have to clean up/migrate the existing databases prior to conversion.
1 participant
Description
Refactors the aws control room & workload and azure workload postgres_config steps from python to go. This has been tested with a control room and 2 workloads, producing no diffs.
Category of change
Checklist