refactor: simplify/reformat existing grafana alerts#142
Merged
Conversation
amdove
changed the title
Lytol
approved these changes
Mar 5, 2026
Contributor
Lytol
left a comment
Lytol
left a comment
There was a problem hiding this comment.
Ooooh, so excited for some more sensible alert copy!
I left an observation, but it's more just thinking aloud... feel free to ignore it entirely if it's not useful.
One other note: are we delineating the alert "criticality" (between critical and warning) in any way aside from the summary copy? It feels like there should be a norm for that.
Contributor
There was a problem hiding this comment.
observation: Obviously much beyond the scope of this PR, but the HUGE inline string configs are kinda annoying IMO. It could be a nice QOL improvement to move those into their own files and then just read them in at runtime. 🤷
Comment on lines
+14
to
+16
| # Human-readable tenant name for alerts (defaults to compound_name if not set) | ||
| tenant_name: "Example Analytics Team" | ||
|
|
stevenolen
reviewed
Mar 5, 2026
Collaborator
stevenolen
left a comment
stevenolen
left a comment
There was a problem hiding this comment.
what he said
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Must be deployed to control rooms and workload clusters. Tenant name will default to compound_name but not until the new update gets applied to the workload cluster. Has already been applied to staging.
Test plan
No new tests added since tenant_name is a cosmetic field with simple fallback logic (tenant_name or compound_name), testing would only verify basic Python language features.
Category of change