upstream merge for vscode python v2025.2.0#6722
Conversation
|
E2E Tests 🚀 |
|
A LOT of this PR is updates to |
| --hash=sha256:eaa912e0b11848c4d9279a93d7e2783df352b082f40111e078388701fd479e53 \ | ||
| --hash=sha256:f35cfccb065fff93529d2afb4a2e89e363fe63ca1e4a5da22b603a85833c2649 \ | ||
| --hash=sha256:fc0ed7fe2231a444fc219b9c42d0376e0a9a1a72f16c5cfa0f68d19f1a0663e8 | ||
| psutil==7.0.0 \ |
There was a problem hiding this comment.
Since this is a major upgrade and psutil includes platform-specific binaries, we should double-check that this doesn't cause any platform-specific build issues after we've merged.
| if selection[-2] == "}" or selection[-2] == "]": | ||
| source = source[:-1] | ||
| # If the selection contains trailing return dictionary, insert newline to trigger execute. | ||
| if check_end_with_return_dict(selection): |
There was a problem hiding this comment.
We use this code so should double-check how this affects Cmd+Enter for lines like return {}. I doubt we've covered that in e2e tests.
There was a problem hiding this comment.
Just checked this out 👀 it looks like it will insert a newline in the script and in the console, but will still execute as expected.
Screen.Recording.2025-03-12.at.12.43.47.PM.mov
| } | ||
| } | ||
|
|
||
| export interface JupyterPythonEnvironmentApi { |
There was a problem hiding this comment.
Probably worth keeping an eye on what this is solving and whether we can/want to use it.
There was a problem hiding this comment.
Here's the upstream PR that added it! microsoft/vscode-python#24771
Looks like it was originally added to have one single way to get the environment for Python scripts/notebooks/etc (and fix a bug where the first selection of a kernel for a Jupyter notebook didn't fire a change event).
|
Awesome, thanks for that update! I kicked off a full run of e2e tests and can merge this once that is certified green ✅ |
3 participants
Release notes for v2025.2.0.
Not too much here that will affect us. The primary work i:
Nearly all of the changed lines are from the
package-lock.json.Release Notes
Maintenance #6581
New Features
Bug Fixes
QA Notes