Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes two libraries from the analysis-runner hail(python base) image:
sample-metadata: this has been replaced bymetamistfor years, and metamist is already installed as part of this command. This combined installation will try and find versions of shared dependencies between the latest and greatest, and the deprecated old codebase still on pypi.cpg-workflows: this isn't a necessary dependency. production-pipelines workflows don't use the naked analysis-runner image, they use(d) the cpg-workflows image. We have also almost entirely migrated off that codebase, so would be using cpg-flow based workflows instead.Fun example of why these should be removed - CPG-Flow replaces cpg-workflows, and CPG-Flow builds a docker image to test workflow logic changes. That image here builds upon this base image, which installs its predecessor. We can test the old and busted alongside the new hotness, which is bloat, as well as potentially some misleading success/failure modes