Conversation
ponylang-main
added
the
discuss during sync
text/0000-add-ansi-escape-codes.md
Outdated
| ## Alternative to the rfc as a whole | ||
| These escape codes can simply be printed independently of whatever is supported by functions on `ANSI`. | ||
| Having them available on `ANSI` simply makes it so that users do not need to look the codes up themselves. |
There was a problem hiding this comment.
I don't understand what you mean by this.
There was a problem hiding this comment.
I do not understand this under the "Alternatives" section.
Co-authored-by: Sean T Allen <sean@seantallen.com>
rhagenson
left a comment
rhagenson
left a comment
There was a problem hiding this comment.
I left some comments mostly about use of default values, additional functionality, preventing errors, and my opinion on the direction I would prefer.
text/0000-add-ansi-escape-codes.md
Outdated
| ## Alternative to the rfc as a whole | ||
| These escape codes can simply be printed independently of whatever is supported by functions on `ANSI`. | ||
| Having them available on `ANSI` simply makes it so that users do not need to look the codes up themselves. |
There was a problem hiding this comment.
I do not understand this under the "Alternatives" section.
|
As discussed in the sync call, I'd like to request that the RFC include the method signatures for the new methods. |
| - The `clear` function moves the cursor to the top left and then clears the screen. | ||
| This may have been done to create the same result that this escape code gave on DOS. |
There was a problem hiding this comment.
| - The `clear` function moves the cursor to the top left and then clears the screen. | |
| This may have been done to create the same result that this escape code gave on DOS. | |
| - The `clear` function moves the cursor to the top left and then clears the screen. | |
| This may have been done to create the same result that this escape code gave on DOS. |
There was a problem hiding this comment.
If that extra newline is added, the next line would be split out into a separate paragraph instead of being attached to the bullet point about the functionality of the current clear function.
| for the parameters. | ||
| To enforce the safety of these functions using the type system, four primitives |
There was a problem hiding this comment.
| for the parameters. | |
| To enforce the safety of these functions using the type system, four primitives | |
| for the parameters. | |
| To enforce the safety of these functions using the type system, four primitives |
|
During sync we discussed that we'd like to see more detailed information about function signnatures for new methods. |
SeanTAllen
removed
the
discuss during sync
ponylang-main
added
the
discuss during sync
Co-authored-by: Borja o'Cook <ergl@users.noreply.github.com>
Co-authored-by: Sean T Allen <sean@seantallen.com>
Co-authored-by: Sean T Allen <sean@seantallen.com>
SeanTAllen
removed
the
discuss during sync
Co-authored-by: Sean T Allen <sean@seantallen.com>
rhagenson
left a comment
rhagenson
left a comment
There was a problem hiding this comment.
Thank you for splitting the modifications into a separate RFC! As well, thank you for adding example codes inline within the added escape codes list -- it is far easier to cross-reference the suggestions here with escape code tables now.
As this RFC stands I see no reason against these additions, although (as discussed on sync by Joe) I would like to see the API being suggested.
6 participants
No description provided.