modules, homestakeros: add 'port' and 'jsonRpcPort' options#78
Open
tupakkatapa wants to merge 3 commits intomainfrom
Open
modules, homestakeros: add 'port' and 'jsonRpcPort' options#78tupakkatapa wants to merge 3 commits intomainfrom
tupakkatapa wants to merge 3 commits intomainfrom
Conversation
Member
|
I'm bit hesitant on merging this before the demo, does this require changes on the frontend? |
Member
Author
|
This can be left hanging and merged some other time, just threw this here on a whim since i saw the comment on the SSV node section. HomestakerOS/nixosModules/homestakeros/default.nix Lines 230 to 231 in 060690f This does not require changes from the frontend, neither it does not play any role in the demo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it is what it is