Skip to content

Add OVH Provider#650

Open
bhubert wants to merge 1 commit intopolymind-inc:masterfrom
bhubert:master
Open

Add OVH Provider#650
bhubert wants to merge 1 commit intopolymind-inc:masterfrom
bhubert:master

Conversation

@bhubert
Copy link
Contributor

@bhubert bhubert commented Dec 12, 2023

I added OVH which is a cloud / DNS / domain provider really popular in France and at least Europe.

The code is complex because their api is complicated to call with a signature to generate based on the content of the call that needs to be added in header on each requests

@bhubert
Copy link
Contributor Author

bhubert commented Dec 17, 2023

hi @shibayan ! do you think you will accept this PR or is OVH to small in your opinion to make it a great addition to your project ?

Copy link
Member

@shibayan shibayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the structure and format of the code should be consistent with other provider implementations. Consistency with other provider implementations must be maintained.

e.g. https://github.com/shibayan/keyvault-acmebot/blob/master/KeyVault.Acmebot/Providers/GoDaddyProvider.cs

@bhubert
Copy link
Contributor Author

bhubert commented Dec 18, 2023

Overall, the structure and format of the code should be consistent with other provider implementations. Consistency with other provider implementations must be maintained.

e.g. https://github.com/shibayan/keyvault-acmebot/blob/master/KeyVault.Acmebot/Providers/GoDaddyProvider.cs

I reordered and rewrote some part of the code to make it looks like GoDaddy provider as much as possible. You were right it's much better like this, thanks !

@bhubert
Copy link
Contributor Author

bhubert commented Mar 24, 2024

Overall, the structure and format of the code should be consistent with other provider implementations. Consistency with other provider implementations must be maintained.
e.g. https://github.com/shibayan/keyvault-acmebot/blob/master/KeyVault.Acmebot/Providers/GoDaddyProvider.cs

I reordered and rewrote some part of the code to make it looks like GoDaddy provider as much as possible. You were right it's much better like this, thanks !

@shibayan it's been a while and i forgot about this PR, could you check if the last version was ok ? thanks !

@bhubert bhubert requested a review from shibayan June 3, 2024 06:36
@CisorKnight
Copy link

Any chance it could be merged in the main?
I would really like to use keyvault-acmebot with ovh as a dns provider

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants