Fixes #491 - Add support for DomeneShop

[eloekset]

An attempt at implementing support for https://domene.shop.

I haven't even tested it once, so don't merge this until it's tested. How can I deploy a PR to my own environment to test it?

[eloekset]

I've tested and verified that this provider now works fine.

[eloekset]

For some reason I'm not able to create a PR for the wiki, but this is the documentation related to this provider:

Domeneshop

App settings

• Acmebot:DomeneShop:ApiKeyUser
  • API user from the token column at domene.shop
• Acmebot:DomeneShop:ApiKeyPassword
  • API password from the secret column at domene.shop

Example API Token configuration

Navigate to https://domene.shop/admin?view=api

[eloekset]

I suspect a bug when trying to delete a TXT record. I made another commit to this branch, which is not merged into this PR yet:
3bd785a

Are you able to confirm how this works @shibayan? I think we should try to refactor the providers to be able to write unit tests for some sample domains and sample inputs to the public methods. That would make it much easier to contribute with additional providers.

[eloekset]

The bug has been fixed and verified with unit tests.

[shibayan]

Acmebot's DNS Provider implementation handles relative record names correctly, so I am not aware of any defects. It is left to the individual DNS Provider implementation.

[eloekset]

The bug is fixed now in this commit and verified with unit tests.

I started off copying the CustomDnsProvider. For some reason the DomeneShopProvider shouldn't combine the relativeRecordName with the DnsZone.Name like the CustomDnsProvider does.

I guess it depends on the implementation of the DNS provider's API whether or not the DnsZone.Name should be included.

[shibayan]

It is a CustomDnsProvider-specific specification, not a bug in Acmebot's implementation; different DNS Providers require different information, so they pass neutral values.

[josteinkirkebak]

What is the status on this? Any hope of having this merged into the main branch? @shibayan

[eloekset]

What is the status on this? Any hope of having this merged into the main branch? @shibayan

You can use my fork if you need support for Domeneshop and/or Namecheap 😃

[jpsalvesen]

Gentle nudge. Domeneshop support would be greatly appreciated.