-
Notifications
You must be signed in to change notification settings - Fork 78
Query with REST API #1302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: staging/product-ia
Are you sure you want to change the base?
Query with REST API #1302
Conversation
nhussein11
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, left some comments
| curl -s "https://polkadot-asset-hub-public-sidecar.parity-chains.parity.io/accounts/14E5nqKAp3oAJcmzgZhUD2RcptBeUBScxKHgJKU4HPNcKVf3/foreign-asset-balances" | ||
| ``` | ||
|
|
||
| ## Running Sidecar Locally |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be moved to the top, right after ##Prerequisites
| ### Request | ||
|
|
||
| ```bash | ||
| curl -s "https://polkadot-asset-hub-public-sidecar.parity-chains.parity.io/accounts/14E5nqKAp3oAJcmzgZhUD2RcptBeUBScxKHgJKU4HPNcKVf3/balance-info" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better and cleaner to show something like:
curl -s "https://polkadot-asset-hub-public-sidecar.parity-chains.parity.io/accounts/INSERT_ADDRESS/balance-info"And the same for the rest. If you consider that's valuable to add a concrete address, that could be done in a collapsible element for example
| | `sufficients` | Number of accounts whose existence is paid for by this asset | | ||
| | `status` | Asset status (Live, Frozen, or Destroying) | | ||
|
|
||
| ## Query Block Information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd move this after foreign assets so it's more consistent; we show all assets-related actions first, then block-related actions.
|
|
||
| For production applications or high-frequency queries, run your own Sidecar instance. | ||
|
|
||
| ### Using npm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about using tabs instead of ###?
|
|
||
| For a complete list of endpoints and parameters, see the [Sidecar API Documentation](https://paritytech.github.io/substrate-api-sidecar/docsv2/){target=\_blank}. | ||
|
|
||
| Common endpoints include: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is redundant, considering all of them where explained above
|
|
||
| [workspace] | ||
| members = ["tutorials/polkadot-sdk/parachains/zero-to-hero/runtime"] | ||
| members = ["dummy"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this needed?
| @@ -0,0 +1,2 @@ | |||
| // Placeholder crate for CI workspace requirements. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think adding these files is a good approach just to satisfy the CI requirements. I'd focus on fixing the CI and investigating why it's failing rather than adding these kinds of files.
π Description
Resolves #1205
π Review Preference
Choose one:
π€ AI-Ready Docs
If content changed, regenerate AI files:
python3 scripts/generate_llms.pyβ Checklist