-
Notifications
You must be signed in to change notification settings - Fork 78
Add estimate fee tx #1279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add estimate fee tx #1279
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds comprehensive documentation and code examples for calculating transaction fees on Polkadot-based chains. It provides practical examples using both Polkadot-API (PAPI) and Polkadot.js API, along with instructions for the Polkadot-JS Apps UI.
Key Changes:
- Complete tutorial documentation covering fee calculation concepts and prerequisites
- TypeScript code examples for both PAPI and Polkadot.js API with detailed explanations
- Expected output samples demonstrating fee estimation results
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
.chain-interactions/send-transactions/calculate-transaction-fees.md |
Main tutorial document explaining transaction fee calculation with three different approaches (PAPI, Polkadot.js API, and UI) |
.snippets/code/chain-interactions/send-transactions/calculate-transaction-fees/polkadotjs-fee-calculator.ts |
Polkadot.js API implementation for fee estimation |
.snippets/code/chain-interactions/send-transactions/calculate-transaction-fees/polkadotjs-fee-calculator-output.html |
Expected terminal output for the Polkadot.js API example |
.snippets/code/chain-interactions/send-transactions/calculate-transaction-fees/papi-fee-calculator.ts |
PAPI implementation for fee estimation |
.snippets/code/chain-interactions/send-transactions/calculate-transaction-fees/papi-fee-calculator-output.html |
Expected terminal output for the PAPI example |
π‘ Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...chain-interactions/send-transactions/calculate-transaction-fees/polkadotjs-fee-calculator.ts
Outdated
Show resolved
Hide resolved
.../code/chain-interactions/send-transactions/calculate-transaction-fees/papi-fee-calculator.ts
Outdated
Show resolved
Hide resolved
.chain-interactions/send-transactions/calculate-transaction-fees.md
Outdated
Show resolved
Hide resolved
...eractions/send-transactions/calculate-transaction-fees/polkadotjs-fee-calculator-output.html
Outdated
Show resolved
Hide resolved
...in-interactions/send-transactions/calculate-transaction-fees/papi-fee-calculator-output.html
Outdated
Show resolved
Hide resolved
58ca464 to
d4ceb56
Compare
.chain-interactions/send-transactions/calculate-transaction-fees.md
Outdated
Show resolved
Hide resolved
.chain-interactions/send-transactions/calculate-transaction-fees.md
Outdated
Show resolved
Hide resolved
.chain-interactions/send-transactions/calculate-transaction-fees.md
Outdated
Show resolved
Hide resolved
...in-interactions/send-transactions/calculate-transaction-fees/papi-fee-calculator-output.html
Outdated
Show resolved
Hide resolved
.../code/chain-interactions/send-transactions/calculate-transaction-fees/papi-fee-calculator.ts
Outdated
Show resolved
Hide resolved
...eractions/send-transactions/calculate-transaction-fees/polkadotjs-fee-calculator-output.html
Outdated
Show resolved
Hide resolved
...chain-interactions/send-transactions/calculate-transaction-fees/polkadotjs-fee-calculator.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Bruno Galvao <brunopgalvao@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
0xlukem
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! I left a few comments
.chain-interactions/send-transactions/calculate-transaction-fees.md
Outdated
Show resolved
Hide resolved
.chain-interactions/send-transactions/calculate-transaction-fees.md
Outdated
Show resolved
Hide resolved
.chain-interactions/send-transactions/calculate-transaction-fees.md
Outdated
Show resolved
Hide resolved
.chain-interactions/send-transactions/calculate-transaction-fees.md
Outdated
Show resolved
Hide resolved
.chain-interactions/send-transactions/calculate-transaction-fees.md
Outdated
Show resolved
Hide resolved
.chain-interactions/send-transactions/calculate-transaction-fees.md
Outdated
Show resolved
Hide resolved
.chain-interactions/send-transactions/calculate-transaction-fees.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Lucas Malizia <131050418+0xlukem@users.noreply.github.com>
eshaben
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed a couple minor things
.chain-interactions/send-transactions/calculate-transaction-fees.md
Outdated
Show resolved
Hide resolved
.chain-interactions/send-transactions/calculate-transaction-fees.md
Outdated
Show resolved
Hide resolved
.chain-interactions/send-transactions/calculate-transaction-fees.md
Outdated
Show resolved
Hide resolved
|
@0xlukem will leave this to you to provide final review π |
π Description
Provide a clear and concise description of your changes.
π Review Preference
Choose one:
π€ AI-Ready Docs
If content changed, regenerate AI files:
python3 scripts/generate_llms.pyβ Checklist