Skip to content

Upkeep#47

Draft
dunkenwg wants to merge 5 commits intomainfrom
upkeep
Draft

Upkeep#47
dunkenwg wants to merge 5 commits intomainfrom
upkeep

Conversation

@dunkenwg
Copy link
Copy Markdown
Contributor

No description provided.

@dunkenwg
Copy link
Copy Markdown
Contributor Author

@joethorley, the GitHub actions in this repo are far more advanced than those in embr so I don't want to go and mess anything up before talking to you. The Smoke test: stock R - Matrix: rcc-suggests - Without ggplot2 action is already failing because jmbr.Rmd uses ggplot2 and the vignette can't build without this package. Do you want me to switch ggplot2 from a suggest to an import in the DESCRIPTION or would you rather solve this in some other way?

@joethorley
Copy link
Copy Markdown
Member

@dunkenwg - good question let's park for now until I have chance to dig into it.

@joethorley joethorley marked this pull request as draft January 29, 2025 23:18
@joethorley
Copy link
Copy Markdown
Member

I've converted to draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants