Skip to content

Work around @_exported-public import bug #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephencelis merged 8 commits into from
Jun 10, 2026
Merged

Work around @_exported-public import bug #477

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
71ca869
Re-export symbols using type aliases, instead
stephencelis Jun 9, 2026
989de96
wip
stephencelis Jun 9, 2026
338e209
wip
stephencelis Jun 9, 2026
e562ee0
Fix
stephencelis Jun 10, 2026
5a3a2d9
fix
stephencelis Jun 10, 2026
e0bc4c6
warnings
stephencelis Jun 10, 2026
de28a3f
bump
stephencelis Jun 10, 2026
f66110c
Revert "warnings"
stephencelis Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 27 additions & 27 deletions Examples/Examples.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions Examples/Reminders/RemindersApp.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ struct RemindersApp: App {
isPresented: $syncEngineDelegate.isDeleteLocalDataAlertPresented
) {
Button("Reset", role: .destructive) {
Task {
_ = Task {
try await syncEngine.deleteLocalData()
}
}
Expand Down Expand Up @@ -100,7 +100,7 @@ class SceneDelegate: UIResponder, UIWindowSceneDelegate {
_ windowScene: UIWindowScene,
userDidAcceptCloudKitShareWith cloudKitShareMetadata: CKShare.Metadata
) {
Task {
_ = Task {
try await syncEngine.acceptShare(metadata: cloudKitShareMetadata)
}
}
Expand All @@ -114,7 +114,7 @@ class SceneDelegate: UIResponder, UIWindowSceneDelegate {
else {
return
}
Task {
_ = Task {
try await syncEngine.acceptShare(metadata: cloudKitShareMetadata)
}
}
Expand Down
2 changes: 1 addition & 1 deletion Examples/Reminders/RemindersDetail.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ class RemindersDetailModel: HashableObject {
}
}

private var remindersQuery: some StructuredQueriesCore.Statement<Row> {
private var remindersQuery: some Statement<Row> & Sendable {
Comment thread
stephencelis marked this conversation as resolved.
Reminder
.where {
if !showCompleted {
Expand Down
2 changes: 1 addition & 1 deletion Examples/Reminders/Schema.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,7 @@ nonisolated func handleReminderStatusUpdate() {

@DatabaseFunction
nonisolated func createDefaultRemindersList() {
Task {
_ = Task {
@Dependency(\.defaultDatabase) var database
try await database.write { db in
try RemindersList.insert {
Expand Down
3 changes: 1 addition & 2 deletions Examples/Reminders/SearchReminders.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import GRDB
import IssueReporting
import SQLiteData
import SwiftUI
Expand Down Expand Up @@ -227,7 +226,7 @@ struct SearchRemindersView: View {
}
Spacer()
Button(model.showCompletedInSearchResults ? "Hide" : "Show") {
Task { try await model.showCompletedButtonTapped() }
_ = Task { try await model.showCompletedButtonTapped() }
}
}
}
Expand Down
1 change: 0 additions & 1 deletion Examples/Reminders/TagsForm.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import GRDB
import SQLiteData
import SwiftUI
import SwiftUINavigation
Expand Down
54 changes: 27 additions & 27 deletions Package.resolved
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 7 additions & 5 deletions Sources/SQLiteData/CloudKit/CloudKitSharing.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
#if canImport(CloudKit)
public import CloudKit
public import Dependencies
import ConcurrencyExtras
import GRDB
public import SwiftUI
import IssueReporting
public import StructuredQueries

#if canImport(UIKit)
#if canImport(SwiftUI) && canImport(UIKit) && !os(tvOS) && !os(watchOS)
public import Dependencies
public import SwiftUI
public import UIKit
#endif

Expand Down Expand Up @@ -255,7 +257,7 @@
}
}

#if canImport(UIKit) && !os(tvOS) && !os(watchOS)
#if canImport(SwiftUI) && canImport(UIKit) && !os(tvOS) && !os(watchOS)
/// A view that presents standard screens for adding and removing people from a CloudKit share \
/// record.
///
Expand Down Expand Up @@ -348,7 +350,7 @@
}

Button("Stop Sharing", role: .destructive) {
Task {
_ = Task {
try await syncEngine.unshare(share: sharedRecord.share)
try await syncEngine.fetchChanges()
dismiss()
Expand Down
Loading