Composer by JaxkDev · Pull Request #3 · poggit/poggit-phpstan

JaxkDev · 2020-11-24T16:02:13Z

Writeup needed.

…d/installed dependencies users can now specify everything* they need in composer.json

- Sorry but it got messy. - Default level changed to 5 - Added composer 'properly'

JaxkDev · 2021-02-15T21:16:03Z

PR Changes:

Most notably composer is now used to control what version pmmp & phpstan are used, however this also means any composer dependencies can also be used in analysis (even if plugins cant dynamically install composer deps via poggit CI yet)
Updated phpstan default config to reflect the changes below and above.
Paths have changed slightly, all data including plugin dependencies are now in /source
Composer v2 must be used to allow use of InstalledVersions.php (Absolutely amazing util saves the ugly hacks...)
PHPStan and PocketMine-MP default versions can be passed via -e when container started meaning they are no longer hard coded and do not require a rebuild of the image.
Bumped phpstan default level back up to 5 :)

Notes:

Because of the runtime installs, this means the phpstan 'process' will take much longer then previously and higher resource usage (potentially more exit cases ? - https://discord.com/channels/402639859535052811/406714907896315915/809097761042858044 assuming these are OOM or similar)
Also because of the lengthened runtime the github webhooks may show as the request timing out.
See https://github.com/CzechPMDevs/BuilderTools/blob/default/composer.json this is a valid composer file and will be used with poggit-phpstan.

Basic tests passed

No composer file in plugin (use default)
Invalid composer file in plugin (bail)
valid composer file with no pmmp (use plugin specified phpstan and default pmmp)
valid composer file with no phpstan (use plugin specified pmmp and default phpstan)

TODO:

Somhow exclude the virion injected code from analysis but not scan. (excludePaths.analyse - But dont have an exact path...)
Test phpstan config files.
Test different ENV variables passed from poggit.
Test inside poggit (this was tested by standalone script replicating poggit behaviour)

NhanAZ · 2022-06-11T18:38:04Z

2 years. This pr is still alone.

SOF3 · 2022-06-12T03:29:54Z

@NhanAZ how is this actually useful to most people anyway? It is just for phpstan analysis, and it's easier to do that on a github action.

JaxkDev · 2023-05-31T21:41:55Z

This might be viable again since new virion spec 3.0 where virions are via composer.json too this solves the analysis problem of shaded virions.

Only remaining issue is PHP binary used.

dktapps

For the PHP version, I think the easiest thing would be to build and tag different images for PM4 and PM5, and then select the appropriate tag based on the API version declared in plugin.yml.

dktapps · 2023-05-31T21:45:57Z

@@ -1,21 +1,41 @@
-FROM pmmp/pocketmine-mp:latest
+FROM ubuntu:18.04 as phpBuild


18.04 is obsolete

dktapps · 2023-05-31T21:46:08Z

+RUN bash compile.sh -t linux64 -f -u -g -l -j
+
+# New slate to lose all unwanted libs (~300mb lost here)
+FROM ubuntu:18.04


Same again here

dktapps · 2023-05-31T21:47:23Z

+RUN mkdir /php
+RUN apt-get update && apt-get install --no-install-recommends -y ca-certificates wget make autoconf automake libtool-bin m4 gzip bzip2 bison g++ git cmake pkg-config re2c
+WORKDIR /php
+RUN wget -q https://raw.githubusercontent.com/pmmp/php-build-scripts/stable/compile.sh


This won't work for PM5.

dktapps · 2023-05-31T22:01:18Z

Is this likely to be merged any time soon, or should I continue working with the existing image?

dktapps · 2023-05-31T22:03:28Z

+RUN apt-get update && apt-get install --no-install-recommends -y ca-certificates wget make autoconf automake libtool-bin m4 gzip bzip2 bison g++ git cmake pkg-config re2c
+WORKDIR /php
+RUN wget -q https://raw.githubusercontent.com/pmmp/php-build-scripts/stable/compile.sh
+RUN bash compile.sh -t linux64 -f -u -g -l -j


These flags will need updating - -u is no longer used and -l now has a different purpose

also, -j expects a value for number of compile threads

JaxkDev · 2023-05-31T22:05:35Z

Is this likely to be merged any time soon, or should I continue working with the existing image?

Ideally I want this to be the way forward, much cleaner just to use composer but it’s a very outdated PR
So anything big probable base off this anything small interim can just go straight

Hopefully I can update my local poggit once PM5 things are updated and continue continue some poggit duct tape

JaxkDev · 2023-05-31T22:06:53Z

Also need to see if this is viable on the server, since it will probably result in higher resource usage per build

SOF3 · 2023-06-01T02:05:28Z

Build rate is not very high, so server resources are sufficient. But I would still advise using GitHub actions for more flexibility.

dktapps · 2023-06-01T02:39:33Z

But I would still advise using GitHub actions for more flexibility.

IMO this is missing the point. Poggit is still going to exist for a while to come and the system should work properly while people continue to use it. I use GitHub Actions for all my plugins, but they still have to be published by Poggit.

SOF3 · 2023-06-01T02:52:54Z

I mean you could just disable the Poggit lint if you already use GitHub CI actively.

dktapps · 2023-06-01T02:53:37Z

I would imagine it's helpful to reviewers to have a quick overview of the plugin's quality, no?

dktapps · 2023-06-01T02:56:53Z

To be clear, the reason I started using Actions is because of Poggit CI's shortcomings, some of which this PR might resolve.

JaxkDev added 2 commits October 17, 2020 18:23

Torture your eyes with the composer update, moving away from hardcode…

fda9dc0

…d/installed dependencies users can now specify everything* they need in composer.json

Changes pre-build, removed useless directories.

87912f9

SOF3 approved these changes Nov 25, 2020

View reviewed changes

JaxkDev added 2 commits February 15, 2021 20:38

Mass amount of changes in one...

7c891be

- Sorry but it got messy. - Default level changed to 5 - Added composer 'properly'

Wrong variables...

dab7ad3

JaxkDev requested a review from SOF3 February 15, 2021 20:51

JaxkDev mentioned this pull request May 31, 2023

PM5 #9

Closed

dktapps reviewed May 31, 2023

View reviewed changes

		@@ -1,21 +1,41 @@
		FROM pmmp/pocketmine-mp:latest
		FROM ubuntu:18.04 as phpBuild

Uh oh!

Conversation

JaxkDev commented Nov 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JaxkDev commented Feb 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NhanAZ commented Jun 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SOF3 commented Jun 12, 2022

Uh oh!

JaxkDev commented May 31, 2023

Uh oh!

dktapps left a comment

Choose a reason for hiding this comment

Uh oh!

dktapps May 31, 2023

Choose a reason for hiding this comment

Uh oh!

dktapps May 31, 2023

Choose a reason for hiding this comment

Uh oh!

dktapps May 31, 2023

Choose a reason for hiding this comment

Uh oh!

dktapps commented May 31, 2023

Uh oh!

dktapps May 31, 2023

Choose a reason for hiding this comment

Uh oh!

JaxkDev commented May 31, 2023

Uh oh!

JaxkDev commented May 31, 2023

Uh oh!

SOF3 commented Jun 1, 2023

Uh oh!

dktapps commented Jun 1, 2023

Uh oh!

SOF3 commented Jun 1, 2023

Uh oh!

dktapps commented Jun 1, 2023

Uh oh!

dktapps commented Jun 1, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

JaxkDev commented Nov 24, 2020 •

edited

Loading

JaxkDev commented Feb 15, 2021 •

edited

Loading

NhanAZ commented Jun 11, 2022 •

edited

Loading