[codex] Lazy parse deprecated iTunes summaries#5
Draft
nathangathright wants to merge 1 commit into
Draft
Conversation
nathangathright
force-pushed
the
codex/lazy-itunes-summary
branch
from
b1ec845 to
2bd4383
Compare
nathangathright
force-pushed
the
codex/lazy-itunes-summary
branch
from
2bd4383 to
2bcf1f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<itunes:summary>values during XML parsing.summaryfields by default for feed and item objects; callers can opt back in withincludeItunesSummary.itunes:summaryas a lazy fallback fordescriptionwhen no better description/content field exists.Why
Some large feeds, including Anchor feeds with long back catalogs, include hundreds of thousands of escaped HTML entities inside
<itunes:summary>. Since the tag is deprecated and usually duplicates<description>, parsing and exposing it eagerly can trip downstream entity expansion limits without adding useful data.Validation
npx jest src/parser/__test__/feed.test.ts src/parser/__test__/item.test.ts --runInBandnpm test -- --runInBandnpm run lint:typechecknpm run buildhttps://anchor.fm/s/7c624c84/podcast/rssfromdistsuccessfully: 1,426 items, no default summary fields.