Open
Conversation
afck
reviewed
Feb 14, 2021
Collaborator
afck
left a comment
There was a problem hiding this comment.
Not sure about this one: I don't think it's idiomatic in Rust to provide a Vec version for functions that take a slice.
If we add a generalization for convenience, I'd make it as general as possible, and actually modify compute_interpolation itself. It just iterates over the samples once anyway, so we could accept any T: IntoIterator where T::Item: Borrow<Fr>. That should make it accept vectors, slices and other iterators and collections.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a helper function I ended up writing while working on an erlang nif for threshold_crypto. Thought it may be helpful to merge upstream.