Latest changes for sokol address, branch agnostic config#17
Open
rstormsf wants to merge 6 commits intopoanetwork:masterfrom
Open
Latest changes for sokol address, branch agnostic config#17rstormsf wants to merge 6 commits intopoanetwork:masterfrom
rstormsf wants to merge 6 commits intopoanetwork:masterfrom
Conversation
Sokol testnet KeysManager address
(Fix) Password for initial key is generated to the file (Sokol)
phahulin
reviewed
Jan 24, 2018
| let contractAddress = config.Ethereum.contracts.KeysManager.addr; | ||
| let contractABI = KeysManagerAbi; | ||
| const network = process.env.NETWORK; | ||
| let contractAddress = config.Ethereum.contracts.KeysManager[network]['addr']; |
Contributor
There was a problem hiding this comment.
Same remark as in poanetwork/poa-scripts-validator#9 applies here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change requires changes in Deployment playbooks
https://github.com/poanetwork/deployment-playbooks/search?utf8=%E2%9C%93&q=SCRIPTS_MOC_BRANCH&type=