Skip to content

fix: use URL.parse instead of deprecated url.parse api#1

Merged
zkochan merged 5 commits into
pnpm:mainfrom
SuperchupuDev:fix/no-deprecated-url-parse
Jul 23, 2025
Merged

fix: use URL.parse instead of deprecated url.parse api#1
zkochan merged 5 commits into
pnpm:mainfrom
SuperchupuDev:fix/no-deprecated-url-parse

Conversation

@SuperchupuDev

@SuperchupuDev SuperchupuDev commented Jul 23, 2025

Copy link
Copy Markdown

needed to solve pnpm/pnpm#9529

version 0.3.0 of this package should be created and released after this gets merged

@zkochan

zkochan commented Jul 23, 2025

Copy link
Copy Markdown
Member

CI is failing

@zkochan zkochan merged commit 746a887 into pnpm:main Jul 23, 2025
0 of 9 checks passed
@SuperchupuDev SuperchupuDev deleted the fix/no-deprecated-url-parse branch July 23, 2025 22:25
@zkochan

zkochan commented Jul 25, 2025

Copy link
Copy Markdown
Member

These change have made pnpm to fail: https://github.com/pnpm/pnpm/actions/runs/16484101720/job/46690610395

I had to revert the update: pnpm/pnpm@1073cec

zkochan referenced this pull request in pnpm/pnpm Jul 25, 2025
Fixes issue introduced by #9790
@SuperchupuDev

Copy link
Copy Markdown
Author

it looks like it failed due to me changing the value of the url option from require('url') to URL without changing it everywhere else. when changing it back, the tests from cache/commands seem to pass now. opened a pr reverting the name change #2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants