fix(DepthOfField): cleanup memory leak#233
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
|
the code seems ok (if I got it right it mostly disposes render targets) but could you also please create a sandbox demo with new DOF code? to test out the effect that it works correctly |
ok I will make it for test it |
|
@talentlessguy Hi I made a code sandbox but it has a problem Actually I fix memory leak by wrapping React Code because EffectComposer of '@react-three/postprocessing' can't get CustomEffect Do you have any ideas? do i add a custom effect in wrong way? I guess if that problem fixed, I'm quite sure it works under the sandbox |
|
🎉 This PR is included in version 2.15.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Hi I found that DepthOfField Component has a Texture Memory leak
so I fix it in PR
you can check memory leak this codeSandbox
Every update of parameter, texture count increase infinitely